From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E56A3C432C0 for ; Thu, 21 Nov 2019 23:35:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B955520674 for ; Thu, 21 Nov 2019 23:35:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="BqN1hGJO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726568AbfKUXfj (ORCPT ); Thu, 21 Nov 2019 18:35:39 -0500 Received: from mail-io1-f68.google.com ([209.85.166.68]:34201 "EHLO mail-io1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726038AbfKUXfj (ORCPT ); Thu, 21 Nov 2019 18:35:39 -0500 Received: by mail-io1-f68.google.com with SMTP id z193so5660850iof.1 for ; Thu, 21 Nov 2019 15:35:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=YfXp9dAFCifzAsNDD+8s62kZcQPezX4O5FWQHhpqQtE=; b=BqN1hGJOCwvFGC6W/9HWEYdcWCfDd1qwQwKBdMQBmKuFbU6Mn35LZViqmjfsTCXCI3 8ONhiGZU8Og6Dt2gUnGCScg91+SYW1IpzMCiLUxXDUTu615UkmlZ0d1FJoJdcr0gQRXl MIGvaI3SgxBF/TFMqv3LPNxvfBdlb1lM8Lc+OQDzSbymySrpTug0MiSJbC/KOtRWNHs6 R8KPqNRrHK89q+JI56tJ86sZcfFESOXT0dBg6y8Og5jwH+9FjHg9Fzhf3nDWNAf0OTU3 gA9P9q6U3s3TgA4eWOAiMqo/tk11fn6JNPEq9jbR+zToyCyyQ5ks5p882ARV0Mbs6JIO DDCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=YfXp9dAFCifzAsNDD+8s62kZcQPezX4O5FWQHhpqQtE=; b=QLeM/GNHb7X2qDpgeKZreYUZHaGRpYXnThyLkowJBHzB/7DMw4J3YWZASGXbZ0s+2X xkt+nUSnRLvCiCcpajBT0VXs1S1+k/jltrPfVLNqfvFzYRbwJnzclXwui6k0YaVNlJuh V3MgMQ6C1qeqYZLaPZgqpLk/Lp3hnt/YMMRNQt9JO8OQzVN+A7seTs1Zo3eGSug4d2w0 hOBPAieH0hEWF+B819n1ib16lpYTvZC9iB6Pil/xk58VUL44VmuaggeRAufsiNpQNxvk nWHFgdyWHHdpOwQ6U+AvagstNtPva9hrtCUnpTu+HEyVq3cu4pjWMLDZWhQ5WJnPmsP1 sGlQ== X-Gm-Message-State: APjAAAVTWcTceipxRi8O3yNpBTxZhHVYdBkujxZ+isZfVqLK3LWcqiOx SmKcG7StbB74iOP9NLJg1F0qEg== X-Google-Smtp-Source: APXvYqxF+L8/HED9jgaPXbxv6bg7yqdfAl3w2owXnlhyeJu4jtszMWICARXD8OCyFjYEuzw15lOvlA== X-Received: by 2002:a5d:9249:: with SMTP id e9mr10471141iol.132.1574379338031; Thu, 21 Nov 2019 15:35:38 -0800 (PST) Received: from yoga (pat_11.qualcomm.com. [192.35.156.11]) by smtp.gmail.com with ESMTPSA id z4sm4486782pfn.80.2019.11.21.15.35.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Nov 2019 15:35:37 -0800 (PST) Date: Thu, 21 Nov 2019 15:35:35 -0800 From: Bjorn Andersson To: Navid Emamdoost Cc: Ohad Ben-Cohen , linux-remoteproc@vger.kernel.org, Navid Emamdoost , LKML Subject: Re: [PATCH] rpmsg: char: release allocated memory Message-ID: <20191121233535.GW18024@yoga> References: <20190917033124.1077-1-navid.emamdoost@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 21 Nov 10:20 PST 2019, Navid Emamdoost wrote: > On Mon, Sep 16, 2019 at 10:31 PM Navid Emamdoost > wrote: > > > > In rpmsg_eptdev_write_iter, if copy_from_iter_full fails the allocated > > buffer needs to be released. > > > > Signed-off-by: Navid Emamdoost > > Would you please review this patch? > I'm sorry, I must have missed to reply as I applied the patch. You can find it in the rpmsg-next branch [1] and it will be part of the pull request for v5.5 [1] https://git.kernel.org/pub/scm/linux/kernel/git/andersson/remoteproc.git/log/?h=rpmsg-next Regards, Bjorn > Thank you, > > > --- > > drivers/rpmsg/rpmsg_char.c | 6 ++++-- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/rpmsg/rpmsg_char.c b/drivers/rpmsg/rpmsg_char.c > > index eea5ebbb5119..c655074c07c2 100644 > > --- a/drivers/rpmsg/rpmsg_char.c > > +++ b/drivers/rpmsg/rpmsg_char.c > > @@ -227,8 +227,10 @@ static ssize_t rpmsg_eptdev_write_iter(struct kiocb *iocb, > > if (!kbuf) > > return -ENOMEM; > > > > - if (!copy_from_iter_full(kbuf, len, from)) > > - return -EFAULT; > > + if (!copy_from_iter_full(kbuf, len, from)) { > > + ret = -EFAULT; > > + goto free_kbuf; > > + } > > > > if (mutex_lock_interruptible(&eptdev->ept_lock)) { > > ret = -ERESTARTSYS; > > -- > > 2.17.1 > > > > > -- > Navid.