From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: linux-rtc@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
Alexandre Belloni <alexandre.belloni@bootlin.com>
Subject: [PATCH 2/8] rtc: ds1374: remove unused variable
Date: Fri, 22 Nov 2019 11:22:06 +0100 [thread overview]
Message-ID: <20191122102212.400158-3-alexandre.belloni@bootlin.com> (raw)
In-Reply-To: <20191122102212.400158-1-alexandre.belloni@bootlin.com>
Fix warning:
drivers/rtc/rtc-ds1374.c: In function ‘ds1374_wdt_disable’:
drivers/rtc/rtc-ds1374.c:442:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
---
drivers/rtc/rtc-ds1374.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/rtc/rtc-ds1374.c b/drivers/rtc/rtc-ds1374.c
index 367497914c10..96eba7606523 100644
--- a/drivers/rtc/rtc-ds1374.c
+++ b/drivers/rtc/rtc-ds1374.c
@@ -439,14 +439,13 @@ static void ds1374_wdt_ping(void)
static void ds1374_wdt_disable(void)
{
- int ret = -ENOIOCTLCMD;
int cr;
cr = i2c_smbus_read_byte_data(save_client, DS1374_REG_CR);
/* Disable watchdog timer */
cr &= ~DS1374_REG_CR_WACE;
- ret = i2c_smbus_write_byte_data(save_client, DS1374_REG_CR, cr);
+ i2c_smbus_write_byte_data(save_client, DS1374_REG_CR, cr);
}
/*
--
2.23.0
next prev parent reply other threads:[~2019-11-22 10:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-22 10:22 [PATCH 0/8] rtc: fix W=1 warnings and errors Alexandre Belloni
2019-11-22 10:22 ` [PATCH 1/8] rtc: sysfs: fix hctosys_show kerneldoc Alexandre Belloni
2019-11-22 10:22 ` Alexandre Belloni [this message]
2019-11-22 10:22 ` [PATCH 3/8] rtc: ds1685: remove set but unused variables Alexandre Belloni
2019-11-23 5:16 ` Joshua Kinard
2019-11-22 10:22 ` [PATCH 4/8] rtc: ds1685: fix build error with make W=1 Alexandre Belloni
2019-11-23 5:19 ` Joshua Kinard
2019-11-26 21:16 ` Alexandre Belloni
2019-11-22 10:22 ` [PATCH 5/8] rtc: m41t80: remove excess kerneldoc Alexandre Belloni
2019-11-22 10:22 ` [PATCH 6/8] rtc: pm8xxx: update kerneldoc for struct pm8xxx_rtc Alexandre Belloni
2019-11-22 10:22 ` [PATCH 7/8] rtc: tegra: remove set but unused variable Alexandre Belloni
2019-11-22 12:46 ` Thierry Reding
2019-11-22 10:22 ` [PATCH 8/8] rtc: v3020: " Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191122102212.400158-3-alexandre.belloni@bootlin.com \
--to=alexandre.belloni@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®