From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5401AC432C0 for ; Sat, 23 Nov 2019 00:40:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2B35A20714 for ; Sat, 23 Nov 2019 00:40:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="yftHYP1S" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726813AbfKWAkz (ORCPT ); Fri, 22 Nov 2019 19:40:55 -0500 Received: from mail-lj1-f193.google.com ([209.85.208.193]:39798 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726752AbfKWAky (ORCPT ); Fri, 22 Nov 2019 19:40:54 -0500 Received: by mail-lj1-f193.google.com with SMTP id e10so188477ljj.6 for ; Fri, 22 Nov 2019 16:40:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=LGmuNByLrRRGPoX7LROr9SUx/jNH7fm6HEWSd41eDAk=; b=yftHYP1SMbEX3og/6Sud/w4boXvOMNgYf3eDoCUvtJt4LeKC7JPHXZ2cjOElUCyt1A hCI4UdarUgATSZtBU59aOUCawYcetoAOFseWvsFNxmFiufCIZsXXpuY5J0ttUOcLNcHf o6zvi//nvrZu8oXeonXOQ0LeOvt9HcRdwPOWCLvM8ljFCgF45O8SUYbOvxpj0vmiIkEY yekSAWmgBwjbN+KFuDhLHXVg8agBLQLJsGKrWydSrGzwp2/PHAAUpmppYRbYB4uaFB80 L3lX61ljuj76d3v3lNLFMo7C1KfVrQGJrDnx5vphoswDRUNYsK5mRfHMZq35XG4+CxdZ rEGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=LGmuNByLrRRGPoX7LROr9SUx/jNH7fm6HEWSd41eDAk=; b=PUZBhlTzSbaDErSdMwTIptDXTaOQ2LUrQxPFR3vb0bSXgOMGUyygj+Qguck/3mrOrS EcLgOxAhZ2QdcaUd+H1HwKHUBS7RMPMPA1xFKPNmSIqED2yIJsodP1brUWdyhKs2j8Ex 9W0qq4UyFM2Vgy6tj8G0cmZ1haiqJ1WUljJcqaN+gz5ucONVmOE7s/AyudeXhKTT4QSf Nb5aNCnrwI+uDwgIlD/AnzChHX6AQwnYyyYANEndLdR0JcXTCk7ZgtWJhmnPrv0QmUrH 33P1rbBTfOh71WoEfPIMy0gX8s8f0FmJlpdJrMCNPwj7sSZVSSkAmTl2ZR36X6P4TQcw vXGQ== X-Gm-Message-State: APjAAAXjYAZ4x0OQFDClAkpwU3jqD05Zw2niV9CZUDYBtac39lolc871 E4BgSjYxTeiapC/KCbR1NL4rsA== X-Google-Smtp-Source: APXvYqw/h7E8n9AmtYOP1hIl5xKQruSU3unBhNrvFvGcELytRTuO4dETAr69gZbDWI95D3vvBogf2A== X-Received: by 2002:a05:651c:331:: with SMTP id b17mr14185318ljp.133.1574469651382; Fri, 22 Nov 2019 16:40:51 -0800 (PST) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id d4sm3746128lfi.32.2019.11.22.16.40.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Nov 2019 16:40:50 -0800 (PST) Date: Fri, 22 Nov 2019 16:40:41 -0800 From: Jakub Kicinski To: Colin King Cc: Ariel Elior , GR-everest-linux-l2@marvell.com, "David S . Miller" , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] qed: remove redundant assignments to rc Message-ID: <20191122164041.1819414b@cakuba.netronome.com> In-Reply-To: <20191122233839.110620-1-colin.king@canonical.com> References: <20191122233839.110620-1-colin.king@canonical.com> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 22 Nov 2019 23:38:39 +0000, Colin King wrote: > diff --git a/drivers/net/ethernet/qlogic/qed/qed_sp_commands.c b/drivers/net/ethernet/qlogic/qed/qed_sp_commands.c > index 7e0b795230b2..12fc5f3b5cb4 100644 > --- a/drivers/net/ethernet/qlogic/qed/qed_sp_commands.c > +++ b/drivers/net/ethernet/qlogic/qed/qed_sp_commands.c > @@ -331,7 +331,7 @@ int qed_sp_pf_start(struct qed_hwfn *p_hwfn, > u8 sb_index = p_hwfn->p_eq->eq_sb_index; > struct qed_spq_entry *p_ent = NULL; > struct qed_sp_init_data init_data; > - int rc = -EINVAL; > + int rc; > u8 page_cnt, i; > > /* update initial eq producer */ I like the clean up but, the variables here are ordered longest to shortest, please don't break people's coding style :(