From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CE33C432C0 for ; Fri, 22 Nov 2019 20:24:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6CC4620679 for ; Fri, 22 Nov 2019 20:24:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="uel7J5JT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727200AbfKVUYD (ORCPT ); Fri, 22 Nov 2019 15:24:03 -0500 Received: from merlin.infradead.org ([205.233.59.134]:43516 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726526AbfKVUYD (ORCPT ); Fri, 22 Nov 2019 15:24:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=bvNE6Zyypz75+7Fq8SroagtNQS0aHPoMp2AN/rY3qo8=; b=uel7J5JTnSuAZnrYyJCsMcyLg FH4pMEQuNE2mqaWy2I8eaU4efPKZoBE+A/KJxl3GB8pyn9Gtv8/lSqyccEYcDBJMDXQaxY7BLl4MU Fp0dBNK1kTucYSVZqNfIZRZwYdhC8lfDN1p7qHd04aXaIgWe5k6BPpfWI2EE5qH1ccVSbSxMGCHW+ hNm4PsbDwKfO7LDqf0N4Z12g2AzWPznXU96/9xQLC9hrqVEq0ET94Mu8SZDPUf3JVpogr0M8LeAm/ 7fn2ksxAYv/mujf2lHFRSSqeHlcuzmjFio0clA/yuTFaW0tiExd+IjhrQQ4RIY+rUo7qXDerqFzbV oHyTD7u3Q==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1iYFT2-00064n-9a; Fri, 22 Nov 2019 20:23:48 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 306CF3056BE; Fri, 22 Nov 2019 21:22:34 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 9FAD320B2867F; Fri, 22 Nov 2019 21:23:45 +0100 (CET) Date: Fri, 22 Nov 2019 21:23:45 +0100 From: Peter Zijlstra To: "Luck, Tony" Cc: Ingo Molnar , "Yu, Fenghua" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , H Peter Anvin , "Raj, Ashok" , "Shankar, Ravi V" , linux-kernel , x86 Subject: Re: [PATCH v10 6/6] x86/split_lock: Enable split lock detection by kernel parameter Message-ID: <20191122202345.GC2844@hirez.programming.kicks-ass.net> References: <1574297603-198156-1-git-send-email-fenghua.yu@intel.com> <1574297603-198156-7-git-send-email-fenghua.yu@intel.com> <20191121060444.GA55272@gmail.com> <20191121130153.GS4097@hirez.programming.kicks-ass.net> <20191121171214.GD12042@gmail.com> <20191121173444.GA5581@agluck-desk2.amr.corp.intel.com> <20191122105141.GY4114@hirez.programming.kicks-ass.net> <20191122152715.GA1909@hirez.programming.kicks-ass.net> <3908561D78D1C84285E8C5FCA982C28F7F4DD20D@ORSMSX115.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3908561D78D1C84285E8C5FCA982C28F7F4DD20D@ORSMSX115.amr.corp.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 22, 2019 at 06:02:04PM +0000, Luck, Tony wrote: > > it requires we get the kernel and firmware clean, but only warns about > > dodgy userspace, which I really don't think there is much of. > > > > getting the kernel clean should be pretty simple. > > Fenghua has a half dozen additional patches (I think they were > all posted in previous iterations of the patch) that were found by > code inspection, rather than by actually hitting them. I thought we merged at least some of that, but maybe my recollection is faulty. > Those should go in ahead of this. Yes, we should make the kernel as clean as possible before doing this.