From: Changbin Du <changbin.du@gmail.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Changbin Du <changbin.du@gmail.com>, Jiri Olsa <jolsa@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 0/2] perf: add support for logging debug messages to file
Date: Sat, 23 Nov 2019 04:07:54 +0000 [thread overview]
Message-ID: <20191123040753.nnbstznsabfltwi6@mail.google.com> (raw)
In-Reply-To: <CAM9d7cjzbfmKdRubMHyOGeN91EZGrF5dF7=xxewjftYo8m15fw@mail.gmail.com>
On Tue, Oct 22, 2019 at 12:35:01AM +0900, Namhyung Kim wrote:
> Hello,
>
> On Fri, Oct 18, 2019 at 9:28 AM Changbin Du <changbin.du@gmail.com> wrote:
> >
> > When in TUI mode, it is impossible to show all the debug messages to
> > console. This make it hard to debug perf issues using debug messages.
> > This patch adds support for logging debug messages to file to resolve
> > this problem.
>
> I thought I implemented a debug message view in TUI mode by saving
> all the messages in a linked list. But it seems not sent to the list and I
> cannot find it now. :(
>
Sounds bad :)
> Anyway I understand your concerns and the changes look ok to me, so
>
> Acked-by: Namhyung Kim <namhyung@kernel.org>
>
Thanks for your review.
next prev parent reply other threads:[~2019-11-23 4:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-18 0:27 Changbin Du
2019-10-18 0:27 ` [PATCH v5 1/2] perf: support multiple debug options separated by ',' Changbin Du
2019-10-18 0:27 ` [PATCH v5 2/2] perf: add support for logging debug messages to file Changbin Du
2019-10-21 15:35 ` [PATCH v5 0/2] " Namhyung Kim
2019-11-23 4:07 ` Changbin Du [this message]
2019-11-23 4:09 ` Changbin Du
2019-11-25 9:27 ` Jiri Olsa
2019-11-25 14:36 ` Changbin Du
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191123040753.nnbstznsabfltwi6@mail.google.com \
--to=changbin.du@gmail.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome