From: Steven Rostedt <rostedt@goodmis.org>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: Kusanagi Kouichi <slash@ac.auone-net.jp>,
Marek Szyprowski <m.szyprowski@samsung.com>,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzk@kernel.org>
Subject: Re: [PATCH] arm: exynos_config: Restore debugfs support
Date: Mon, 25 Nov 2019 09:39:32 -0500 [thread overview]
Message-ID: <20191125093932.4a111dc8@gandalf.local.home> (raw)
In-Reply-To: <7f6a5924-58f9-aafb-18c5-c749ad355a02@samsung.com>
On Mon, 25 Nov 2019 15:30:39 +0100
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> wrote:
> It seems that commit 0e4a459f56c3 ("tracing: Remove unnecessary DEBUG_FS
> dependency") disabled DEBUG_FS also in some other ARM defconfigs.
>
> For some of them it may be a correct change but a preferred way to
> introduce such changes would be to:
>
> - add explicit CONFIG_DEBUG_FS=y instances to all affected defconfigs
> while removing DEBUG_FS selection from TRACING config item
>
I strongly disagree. It was wrong to assume DEBUG_FS is attached to
TRACING. If someone wanted DEBUG_FS in their def config, they should
have added it specifically. The addition of DEBUG_FS to defconfigs no
way belongs to the patch that removed DEBUG_FS from TRACING.
-- Steve
> - let platform maintainers disable DEBUG_FS manually in corresponding
> defconfigs later if desirable
next prev parent reply other threads:[~2019-11-25 14:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20191125125531eucas1p17f4044301903eeafe56865ed63738798@eucas1p1.samsung.com>
2019-11-25 12:55 ` Marek Szyprowski
2019-11-25 14:30 ` Bartlomiej Zolnierkiewicz
2019-11-25 14:39 ` Steven Rostedt [this message]
2019-11-25 15:31 ` Bartlomiej Zolnierkiewicz
2019-11-26 1:21 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191125093932.4a111dc8@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=b.zolnierkie@samsung.com \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=slash@ac.auone-net.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®