From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FE91C432C0 for ; Mon, 25 Nov 2019 11:28:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4F96D2085B for ; Mon, 25 Nov 2019 11:28:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725906AbfKYL2U (ORCPT ); Mon, 25 Nov 2019 06:28:20 -0500 Received: from foss.arm.com ([217.140.110.172]:49026 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727743AbfKYL2Q (ORCPT ); Mon, 25 Nov 2019 06:28:16 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5E2D3113E; Mon, 25 Nov 2019 03:28:16 -0800 (PST) Received: from e107158-lin.cambridge.arm.com (e107158-lin.cambridge.arm.com [10.1.195.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 27BC23F52E; Mon, 25 Nov 2019 03:28:15 -0800 (PST) From: Qais Yousef To: Thomas Gleixner , Greg Kroah-Hartman Cc: Qais Yousef , "David S. Miller" , Bjorn Helgaas , "Rafael J. Wysocki" , Sakari Ailus , sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 07/14] sparc: Replace cpu_up/down with device_online/offline Date: Mon, 25 Nov 2019 11:27:47 +0000 Message-Id: <20191125112754.25223-8-qais.yousef@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191125112754.25223-1-qais.yousef@arm.com> References: <20191125112754.25223-1-qais.yousef@arm.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The core device API performs extra housekeeping bits that are missing from directly calling cpu_up/down. See commit a6717c01ddc2 ("powerpc/rtas: use device model APIs and serialization during LPM") for an example description of what might go wrong. This also prepares to make cpu_up/down a private interface for anything but the cpu subsystem. Acked-by: David S. Miller Signed-off-by: Qais Yousef CC: "David S. Miller" CC: Thomas Gleixner CC: Bjorn Helgaas CC: "Rafael J. Wysocki" CC: Greg Kroah-Hartman CC: Sakari Ailus CC: sparclinux@vger.kernel.org CC: linux-kernel@vger.kernel.org --- arch/sparc/kernel/ds.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/arch/sparc/kernel/ds.c b/arch/sparc/kernel/ds.c index bbf59b3b4af8..39350e5dbaf1 100644 --- a/arch/sparc/kernel/ds.c +++ b/arch/sparc/kernel/ds.c @@ -550,12 +550,13 @@ static int dr_cpu_configure(struct ds_info *dp, struct ds_cap_state *cp, mdesc_populate_present_mask(mask); mdesc_fill_in_cpu_data(mask); + lock_device_hotplug(); for_each_cpu(cpu, mask) { int err; printk(KERN_INFO "ds-%llu: Starting cpu %d...\n", dp->id, cpu); - err = cpu_up(cpu); + err = device_online(get_cpu_device(cpu)); if (err) { __u32 res = DR_CPU_RES_FAILURE; __u32 stat = DR_CPU_STAT_UNCONFIGURED; @@ -574,6 +575,7 @@ static int dr_cpu_configure(struct ds_info *dp, struct ds_cap_state *cp, dr_cpu_mark(resp, cpu, ncpus, res, stat); } } + unlock_device_hotplug(); spin_lock_irqsave(&ds_lock, flags); __ds_send(dp->lp, resp, resp_len); @@ -606,17 +608,19 @@ static int dr_cpu_unconfigure(struct ds_info *dp, resp_len, ncpus, mask, DR_CPU_STAT_UNCONFIGURED); + lock_device_hotplug(); for_each_cpu(cpu, mask) { int err; printk(KERN_INFO "ds-%llu: Shutting down cpu %d...\n", dp->id, cpu); - err = cpu_down(cpu); + err = device_offline(get_cpu_device(cpu)); if (err) dr_cpu_mark(resp, cpu, ncpus, DR_CPU_RES_FAILURE, DR_CPU_STAT_CONFIGURED); } + unlock_device_hotplug(); spin_lock_irqsave(&ds_lock, flags); __ds_send(dp->lp, resp, resp_len); -- 2.17.1