From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA0EDC432C0 for ; Mon, 25 Nov 2019 12:43:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8B4372071E for ; Mon, 25 Nov 2019 12:43:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727535AbfKYMnv (ORCPT ); Mon, 25 Nov 2019 07:43:51 -0500 Received: from szxga07-in.huawei.com ([45.249.212.35]:44254 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725823AbfKYMnv (ORCPT ); Mon, 25 Nov 2019 07:43:51 -0500 Received: from DGGEMS403-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 0B714EF4C4A529C8E644; Mon, 25 Nov 2019 20:43:44 +0800 (CST) Received: from localhost.localdomain.localdomain (10.175.113.25) by DGGEMS403-HUB.china.huawei.com (10.3.19.203) with Microsoft SMTP Server id 14.3.439.0; Mon, 25 Nov 2019 20:43:36 +0800 From: Mao Wenan To: , , , , , CC: , , , Mao Wenan Subject: [PATCH net v3] net: dsa: ocelot: add dependency for NET_DSA_MSCC_FELIX Date: Mon, 25 Nov 2019 20:41:10 +0800 Message-ID: <20191125124110.145595-1-maowenan@huawei.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <3e9d6100-6965-da85-c310-6e1a9318f61d@huawei.com> References: <3e9d6100-6965-da85-c310-6e1a9318f61d@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If CONFIG_NET_DSA_MSCC_FELIX=y, and CONFIG_NET_VENDOR_MICROSEMI=n, below errors can be found: drivers/net/dsa/ocelot/felix.o: In function `felix_vlan_del': felix.c:(.text+0x26e): undefined reference to `ocelot_vlan_del' drivers/net/dsa/ocelot/felix.o: In function `felix_vlan_add': felix.c:(.text+0x352): undefined reference to `ocelot_vlan_add' and warning as below: WARNING: unmet direct dependencies detected for MSCC_OCELOT_SWITCH Depends on [n]: NETDEVICES [=y] && ETHERNET [=y] && NET_VENDOR_MICROSEMI [=n] && NET_SWITCHDEV [=y] && HAS_IOMEM [=y] Selected by [y]: NET_DSA_MSCC_FELIX [=y] && NETDEVICES [=y] && HAVE_NET_DSA [=y] && NET_DSA [=y] && PCI [=y] This patch is to select NET_VENDOR_MICROSEMI and add dependency NET_SWITCHDEV, HAS_IOMEM for NET_DSA_MSCC_FELIX. Fixes: 56051948773e ("net: dsa: ocelot: add driver for Felix switch family") Signed-off-by: Mao Wenan --- v3: add depends on NET_SWITCHDEV and HAS_IOMEM. v2: modify 'depends on' to 'select'. drivers/net/dsa/ocelot/Kconfig | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/dsa/ocelot/Kconfig b/drivers/net/dsa/ocelot/Kconfig index 0031ca814346..1ec2dfbd76ce 100644 --- a/drivers/net/dsa/ocelot/Kconfig +++ b/drivers/net/dsa/ocelot/Kconfig @@ -2,6 +2,9 @@ config NET_DSA_MSCC_FELIX tristate "Ocelot / Felix Ethernet switch support" depends on NET_DSA && PCI + depends on NET_SWITCHDEV + depends on HAS_IOMEM + select NET_VENDOR_MICROSEMI select MSCC_OCELOT_SWITCH select NET_DSA_TAG_OCELOT help -- 2.20.1