From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: Mike Snitzer <msnitzer@redhat.com>,
Nikos Tsironis <ntsironis@arrikto.com>,
Scott Wood <swood@redhat.com>,
Ilias Tsitsimpis <iliastsi@arrikto.com>,
dm-devel@redhat.com, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, Daniel Wagner <dwagner@suse.de>,
linux-rt-users@vger.kernel.org, tglx@linutronix.de
Subject: Re: [PATCH RT 1/2 v2] dm-snapshot: fix crash with the realtime kernel
Date: Mon, 25 Nov 2019 18:25:12 +0100 [thread overview]
Message-ID: <20191125172512.q65pmda66un3cm2e@linutronix.de> (raw)
In-Reply-To: <alpine.LRH.2.02.1911121057490.12815@file01.intranet.prod.int.rdu2.redhat.com>
On 2019-11-12 11:09:51 [-0500], Mikulas Patocka wrote:
> ===================================================================
> --- linux-2.6.orig/drivers/md/dm-snap.c 2019-11-12 16:44:36.000000000 +0100
> +++ linux-2.6/drivers/md/dm-snap.c 2019-11-12 17:01:46.000000000 +0100
…
> static void dm_exception_table_lock(struct dm_exception_table_lock *lock)
> {
> +#ifndef CONFIG_PREEMPT_RT_BASE
> hlist_bl_lock(lock->complete_slot);
> hlist_bl_lock(lock->pending_slot);
> +#else
> + spin_lock(lock->lock);
if you also set the lowest bit for complete_slot + pending_slot then
patch 2 of this mini series wouldn't be required. That means we could
keep the debug code on -RT. Or am I missing something?
> +#endif
> }
Sebastian
prev parent reply other threads:[~2019-11-25 17:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 16:09 Mikulas Patocka
2019-11-13 9:20 ` Nikos Tsironis
2019-11-19 8:48 ` Sebastian Andrzej Siewior
2019-11-25 17:25 ` Sebastian Andrzej Siewior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191125172512.q65pmda66un3cm2e@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=dm-devel@redhat.com \
--cc=dwagner@suse.de \
--cc=iliastsi@arrikto.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=msnitzer@redhat.com \
--cc=ntsironis@arrikto.com \
--cc=swood@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®