From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7D6EC432C0 for ; Tue, 26 Nov 2019 08:13:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8E5BC2073F for ; Tue, 26 Nov 2019 08:13:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574755985; bh=K4/HkReIZHrO5EOLAYxEYM72msVBHQIR4SGBUnnMj+g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=CWw9/Gg/i8WrkIbQD/en4ikWBgJIoQa19A0od50TFclZwV84h6Cehagh4N7eA2p2i rCI3u2DaxfAetVwkTbvaCoq5Hri8giHE2qgUpudK651ad/rHsQwNeZ70GLW7y+omtW jUmhWWpE/RcE5Et9RCzOtmLG+b3WvAThkf1m3c/g= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727287AbfKZINC (ORCPT ); Tue, 26 Nov 2019 03:13:02 -0500 Received: from mail.kernel.org ([198.145.29.99]:57488 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727016AbfKZINC (ORCPT ); Tue, 26 Nov 2019 03:13:02 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 279CE2073F; Tue, 26 Nov 2019 08:13:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574755980; bh=K4/HkReIZHrO5EOLAYxEYM72msVBHQIR4SGBUnnMj+g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=0J/UfMLdTXQOEdPa8OBVc2zM5FSC0jOWmtISPlva5y3Rkl5I4VEFoie7afPQmLucJ FuD9S6AXb5BAnFrt5dlO0hXk4nVbCmC+7jFjh3oHi8UPZEA6js4fkWFqGDQ+YoGdhS KCXdocgCSWUnoLRMkYJwpkN5hTQFfpNnDkrCPHR0= Date: Tue, 26 Nov 2019 09:12:58 +0100 From: Greg Kroah-Hartman To: Marcel Holtmann Cc: Alexander Potapenko , Tomas Bortoli , Johan Hedberg , Bluez mailing list , lkml , syzkaller , syzbot+a0d209a4676664613e76@syzkaller.appspotmail.com Subject: Re: [PATCH] Fix invalid-free in bcsp_close() Message-ID: <20191126081258.GA1233188@kroah.com> References: <000000000000109f9605964acf6c@google.com> <20191101204244.14509-1-tomasbortoli@gmail.com> <8376D008-EA21-49EA-AF5A-DDDCB179EAC5@holtmann.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8376D008-EA21-49EA-AF5A-DDDCB179EAC5@holtmann.org> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 26, 2019 at 07:18:46AM +0100, Marcel Holtmann wrote: > Hi Alexander, > > >>> Syzbot reported an invalid-free that I introduced fixing a memleak. > >>> > >>> bcsp_recv() also frees bcsp->rx_skb but never nullifies its value. > >>> Nullify bcsp->rx_skb every time it is freed. > >>> > >>> Signed-off-by: Tomas Bortoli > >>> Reported-by: syzbot+a0d209a4676664613e76@syzkaller.appspotmail.com > >>> --- > >>> drivers/bluetooth/hci_bcsp.c | 3 +++ > >>> 1 file changed, 3 insertions(+) > >> > >> patch has been applied to bluetooth-next tree. > > I believe this bug requires stable tags, as it can potentially provide > > an arbitrary write (via __skb_unlink) and is triggerable locally with > > user privileges. > > I do not have a reproducer for it, but if you do, feel free to propose it for -stable inclusion. Now queued up, thanks. greg k-h