From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97335C43215 for ; Tue, 26 Nov 2019 22:14:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6D7F02064B for ; Tue, 26 Nov 2019 22:14:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726987AbfKZWOM (ORCPT ); Tue, 26 Nov 2019 17:14:12 -0500 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:55561 "EHLO relay9-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726072AbfKZWOM (ORCPT ); Tue, 26 Nov 2019 17:14:12 -0500 X-Originating-IP: 90.65.92.102 Received: from localhost (lfbn-1-1723-102.w90-65.abo.wanadoo.fr [90.65.92.102]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 4D95CFF809; Tue, 26 Nov 2019 22:14:05 +0000 (UTC) Date: Tue, 26 Nov 2019 23:14:04 +0100 From: Alexandre Belloni To: Colin King Cc: Alessandro Zummo , Kevin Hilman , linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] rtc: meson: remove redundant assignment to variable retries Message-ID: <20191126221404.GT299836@piout.net> References: <20191122225210.109172-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191122225210.109172-1-colin.king@canonical.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22/11/2019 22:52:10+0000, Colin King wrote: > From: Colin Ian King > > The variable retries is being initialized with a value that is never > read and it is being updated later with a new value in a for-loop. > The initialization is redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King > --- > drivers/rtc/rtc-meson.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Applied, thanks. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com