From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 260ADC432C3 for ; Wed, 27 Nov 2019 06:59:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F1E8120665 for ; Wed, 27 Nov 2019 06:59:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574837948; bh=zK1jCwlGOD78VxyRYdiQ6t+wN6eJspibjYTJfiHAKZQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=q3LjOvd11NJTfAortigkKQhlHBW2rtbDbgvKilG19UTrKhg+L7CesK7TT/OMtHpsW Nf90yaNaKOD58nmbCBSgYfMf8D3H67e0iUulDRQg3pl5EYkZWVdbzAdpIKuowDT8PQ //cF2as0Zm8ArDnUuozAHxjD9lvv0vn/iuj9Z60s= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726146AbfK0G7G (ORCPT ); Wed, 27 Nov 2019 01:59:06 -0500 Received: from mail.kernel.org ([198.145.29.99]:47888 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726026AbfK0G7G (ORCPT ); Wed, 27 Nov 2019 01:59:06 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F410320665; Wed, 27 Nov 2019 06:59:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574837945; bh=zK1jCwlGOD78VxyRYdiQ6t+wN6eJspibjYTJfiHAKZQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Nfhs7ssBftD+Mla9meYRq1vCMBrSJKx547gAd6rSP8aIjOOI2qauAyKMhSvV/7FSC sPtAYOWwFIWOA2gSoD+79mwGyX0raoNh9UohHsXsJvPwqokDmzZenbE2lr0WwxY6lb WEZeU9bJ2EiT1QxAaaCXIU4oQFbGx60wD2rvr3Nk= Date: Wed, 27 Nov 2019 07:59:03 +0100 From: Greg KH To: Je Yen Tam Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Revert "serial/8250: Add support for NI-Serial PXI/PXIe+485 devices" Message-ID: <20191127065903.GA1725222@kroah.com> References: <20191127031751.9082-1-je.yen.tam@ni.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191127031751.9082-1-je.yen.tam@ni.com> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 27, 2019 at 11:17:51AM +0800, Je Yen Tam wrote: > This reverts commit fdc2de87124f5183a98ea7eced1f76dbdba22951 which is > commit 225607f75454 ("serial/8250: Add support for NI-Serial PXI/PXIe+485 devices"). That sentance does not make sense. fdc2de87124f ("serial/8250: Add support for NI-Serial PXI/PXIe+485 devices") is in the 5.4 kernel tree, where did the commit id "225607f75454" come from? I don't see it anywhere in Linus's tree. > The upstream introduced a breakage on NI-Serial PXI(e)-RS485 devices, > RS-232 variants have no issue. The Linux system can enumerate the Serial > PXI(e)-RS485 devices, but it broke the R/W operation on the ports. I can not parse this paragraph either, what do you mean by "The upstream"? > However, the implementation is working on the NI internal Linux RT kernel > but it does not work in the Linux main tree kernel. This is only affecting > NI products, specifically the RS-485 variants. Reverting the upstream > until a proper implementation that can apply to both NI internal Linux > kernel and Linux mainline kernel is figured out. So this patch really does not work at all? Can't you just find a simple fix to go on top of it to resolve the issue? You really want it all ripped out for 5.5 and 5.4.y? thanks, greg k-h