mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kefeng Wang <wangkefeng.wang@huawei.com>
To: <pmladek@suse.com>, <joe@perches.com>, <linux-kernel@vger.kernel.org>
Cc: <gregkh@linuxfoundation.org>, <tj@kernel.org>, <arnd@arndb.de>,
	<sergey.senozhatsky@gmail.com>, <rostedt@goodmis.org>,
	Kefeng Wang <wangkefeng.wang@huawei.com>,
	Andy Whitcroft <apw@canonical.com>
Subject: [PATCH 4/4] checkpatch: Drop pr_warning check
Date: Thu, 28 Nov 2019 08:47:52 +0800	[thread overview]
Message-ID: <20191128004752.35268-5-wangkefeng.wang@huawei.com> (raw)
In-Reply-To: <20191128004752.35268-1-wangkefeng.wang@huawei.com>

All pr_warning are removed from kernel, let's cleanup pr_warning
check in checkpatch.

Cc: Andy Whitcroft <apw@canonical.com>
Cc: Joe Perches <joe@perches.com>
Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
---
 scripts/checkpatch.pl | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 64890be3c8fd..447c0050eec0 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -4113,15 +4113,6 @@ sub process {
 			     "Prefer [subsystem eg: netdev]_$level2([subsystem]dev, ... then dev_$level2(dev, ... then pr_$level(...  to printk(KERN_$orig ...\n" . $herecurr);
 		}
 
-		if ($line =~ /\bpr_warning\s*\(/) {
-			if (WARN("PREFER_PR_LEVEL",
-				 "Prefer pr_warn(... to pr_warning(...\n" . $herecurr) &&
-			    $fix) {
-				$fixed[$fixlinenr] =~
-				    s/\bpr_warning\b/pr_warn/;
-			}
-		}
-
 		if ($line =~ /\bdev_printk\s*\(\s*KERN_([A-Z]+)/) {
 			my $orig = $1;
 			my $level = lc($orig);
-- 
2.20.1


  parent reply	other threads:[~2019-11-28  0:50 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-28  0:47 [PATCH 0/4] part2: kill pr_warning from kernel Kefeng Wang
2019-11-28  0:47 ` [PATCH 1/4] workqueue: Use pr_warn instead of pr_warning Kefeng Wang
2019-12-02 18:00   ` Tejun Heo
2019-11-28  0:47 ` [PATCH 2/4] staging: isdn: gigaset: " Kefeng Wang
2019-11-29 11:49   ` Petr Mladek
2019-11-28  0:47 ` [PATCH 3/4] printk: Drop pr_warning definition Kefeng Wang
2019-11-28  7:14   ` kbuild test robot
2019-11-29 11:53     ` Petr Mladek
2019-11-30  9:03       ` [kbuild-all] " Philip Li
2019-12-03  9:15         ` Petr Mladek
2019-11-28  0:47 ` Kefeng Wang [this message]
2019-11-28  1:05   ` [PATCH 4/4] checkpatch: Drop pr_warning check Joe Perches
2019-11-29 11:58 ` [PATCH 0/4] part2: kill pr_warning from kernel Petr Mladek
2019-11-29 12:56   ` Kefeng Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191128004752.35268-5-wangkefeng.wang@huawei.com \
    --to=wangkefeng.wang@huawei.com \
    --cc=apw@canonical.com \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmladek@suse.com \
    --cc=rostedt@goodmis.org \
    --cc=sergey.senozhatsky@gmail.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®