From: Viresh Kumar <viresh.kumar@linaro.org>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: Dietmar Eggemann <dietmar.eggemann@arm.com>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
Liviu Dudau <liviu.dudau@arm.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Morten Rasmussen <morten.rasmussen@arm.com>,
Lukasz Luba <lukasz.luba@arm.com>,
linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cpufreq: vexpress-spc: Fix wrong alternation of policy->related_cpus during CPU hp
Date: Thu, 28 Nov 2019 08:01:16 +0530 [thread overview]
Message-ID: <20191128023116.3skwbeowk7wtjaxc@vireshk-i7> (raw)
In-Reply-To: <20191127154029.GA4826@bogus>
On 27-11-19, 15:40, Sudeep Holla wrote:
> diff --git i/arch/arm/mach-vexpress/spc.c w/arch/arm/mach-vexpress/spc.c
> index 354e0e7025ae..e0e2e789a0b7 100644
> --- i/arch/arm/mach-vexpress/spc.c
> +++ w/arch/arm/mach-vexpress/spc.c
> @@ -551,8 +551,9 @@ static struct clk *ve_spc_clk_register(struct device *cpu_dev)
>
> static int __init ve_spc_clk_init(void)
> {
> - int cpu;
> + int cpu, cluster;
> struct clk *clk;
> + bool init_opp_table[MAX_CLUSTERS] = { false };
>
> if (!info)
> return 0; /* Continue only if SPC is initialised */
> @@ -578,8 +579,17 @@ static int __init ve_spc_clk_init(void)
> continue;
> }
>
> + cluster = topology_physical_package_id(cpu_dev->id);
> + if (init_opp_table[cluster])
> + continue;
> +
> if (ve_init_opp_table(cpu_dev))
> pr_warn("failed to initialise cpu%d opp table\n", cpu);
> + else if (dev_pm_opp_set_sharing_cpus(cpu_dev,
> + topology_core_cpumask(cpu_dev->id)))
> + pr_warn("failed to mark OPPs shared for cpu%d\n", cpu);
> +
> + init_opp_table[cluster] = true;
> }
>
> platform_device_register_simple("vexpress-spc-cpufreq", -1, NULL, 0);
> diff --git i/drivers/cpufreq/vexpress-spc-cpufreq.c w/drivers/cpufreq/vexpress-spc-cpufreq.c
> index 506e3f2bf53a..83c85d3d67e3 100644
> --- i/drivers/cpufreq/vexpress-spc-cpufreq.c
> +++ w/drivers/cpufreq/vexpress-spc-cpufreq.c
> @@ -434,7 +434,7 @@ static int ve_spc_cpufreq_init(struct cpufreq_policy *policy)
> if (cur_cluster < MAX_CLUSTERS) {
> int cpu;
>
> - cpumask_copy(policy->cpus, topology_core_cpumask(policy->cpu));
> + dev_pm_opp_get_sharing_cpus(cpu_dev, policy->cpus);
>
> for_each_cpu(cpu, policy->cpus)
> per_cpu(physical_cluster, cpu) = cur_cluster;
This is a better *work-around* I would say, as we can't break it the
way I explained earlier :)
--
viresh
next prev parent reply other threads:[~2019-11-28 2:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 11:48 Dietmar Eggemann
2019-11-27 12:07 ` Viresh Kumar
2019-11-27 12:10 ` Sudeep Holla
2019-11-27 12:08 ` Sudeep Holla
2019-11-27 12:14 ` Viresh Kumar
2019-11-27 13:32 ` Sudeep Holla
2019-11-27 14:58 ` Dietmar Eggemann
2019-11-27 15:40 ` Sudeep Holla
2019-11-27 18:45 ` Sudeep Holla
2019-11-28 2:31 ` Viresh Kumar [this message]
2019-11-28 10:01 ` Dietmar Eggemann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191128023116.3skwbeowk7wtjaxc@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=dietmar.eggemann@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=liviu.dudau@arm.com \
--cc=lorenzo.pieralisi@arm.com \
--cc=lukasz.luba@arm.com \
--cc=morten.rasmussen@arm.com \
--cc=rjw@rjwysocki.net \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®