From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E4DBC432C0 for ; Thu, 28 Nov 2019 10:35:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 66BED21781 for ; Thu, 28 Nov 2019 10:35:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574937322; bh=hItJyUF8hUfjd0/rGoU4MIjVuZJ5u4q7RJPGnKhD4DQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=umL8sQykNtf2puO5ZWf84f2B7O/Oxx4yQe+pnQcnw/g6UImVjsX7q/55M9KfQLjOx Yd/F1cPL240VaBqgAFJsikSBlO9TNnGnCwwcJH7H61JFGw/ZeirdU5aJBPfKah9fLM VnXo+9CoXABQ6ussByBALYOpnjOYwu5gr/6MJfEs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726594AbfK1KfV (ORCPT ); Thu, 28 Nov 2019 05:35:21 -0500 Received: from mail.kernel.org ([198.145.29.99]:48414 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726191AbfK1KfV (ORCPT ); Thu, 28 Nov 2019 05:35:21 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C2C6021774; Thu, 28 Nov 2019 10:35:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574937320; bh=hItJyUF8hUfjd0/rGoU4MIjVuZJ5u4q7RJPGnKhD4DQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=1bpz61K8W31vQA+wq84WRHnL3qDZsEdf7JM+xzGz2lGCNJK4WPETlhgWwqxNzPBQl mH2E5+zddm9eNEPLQMHgD3qc5PEOqi1SZXmz39rbB9qmZ92oMfoGeGeN8Yxlq5/rgZ PdoOTbFkZJ8+8pN2XoPE39ZQVKVrl2wizVWtMz6M= Date: Thu, 28 Nov 2019 11:35:18 +0100 From: Greg Kroah-Hartman To: Jon Hunter Cc: Guenter Roeck , linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, shuah@kernel.org, patches@kernelci.org, ben.hutchings@codethink.co.uk, lkft-triage@lists.linaro.org, stable@vger.kernel.org, linux-tegra Subject: Re: [PATCH 4.4 000/159] 4.4.203-stable review Message-ID: <20191128103518.GA3399855@kroah.com> References: <20191122134131.GA2050590@kroah.com> <20191122134627.GB2050590@kroah.com> <9f976044-2dbc-6c19-11e7-210cd7ab35ea@nvidia.com> <7edc9531-347e-9ac7-2583-5efb49acffdb@nvidia.com> <20191125094116.GA2340170@kroah.com> <20191125160305.GD2683321@kroah.com> <013aa2b3-9a68-6227-36bc-093d03547fce@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 28, 2019 at 09:26:25AM +0000, Jon Hunter wrote: > > On 25/11/2019 22:45, Jon Hunter wrote: > > > > On 25/11/2019 16:03, Greg Kroah-Hartman wrote: > >> On Mon, Nov 25, 2019 at 01:22:58PM +0000, Jon Hunter wrote: > >>> > >>> On 25/11/2019 09:41, Greg Kroah-Hartman wrote: > >>>> On Sun, Nov 24, 2019 at 08:31:46PM +0000, Jon Hunter wrote: > >>>>> > >>>>> On 23/11/2019 15:46, Guenter Roeck wrote: > >>>>>> On 11/22/19 6:48 AM, Jon Hunter wrote: > >>>>>> > >>>>>> [ ... ] > >>>>>> > >>>>>>> Error: arch/arm/boot/dts/omap5-board-common.dtsi:636.1-6 Label or path > >>>>>>> dwc3 not found > >>>>>>> FATAL ERROR: Syntax error parsing input tree > >>>>>>> scripts/Makefile.lib:293: recipe for target > >>>>>>> 'arch/arm/boot/dts/omap5-igep0050.dtb' failed > >>>>>>> make[1]: *** [arch/arm/boot/dts/omap5-igep0050.dtb] Error 1 > >>>>>>> arch/arm/Makefile:338: recipe for target 'dtbs' failed > >>>>>>> make: *** [dtbs] Error 2 > >>>>>>> > >>>>>>> > >>>>>>> This is caused by the following commit ... > >>>>>>> > >>>>>>> commit d0abc07b3d752cbe2a8d315f662c53c772caed0f > >>>>>>> Author: H. Nikolaus Schaller > >>>>>>> Date:   Fri Sep 28 17:54:00 2018 +0200 > >>>>>>> > >>>>>>>      ARM: dts: omap5: enable OTG role for DWC3 controller > >>>>>>> > >>>>>> > >>>>>> On top of the breakage caused by this patch, I would also argue > >>>>>> that it is not a bug fix and should not have been included > >>>>>> in the first place. > >>>>>> > >>>>>> The dwc3 label was added with commit 4c387984618fe ("ARM: dts: omap5: > >>>>>> Add l4 interconnect hierarchy and ti-sysc data"). Given the size of > >>>>>> that patch, I highly doubt that a backport to 4.4 would work. > >>>> > >>>> Good catch, I have now dropped both of these patches and pushed out a > >>>> -rc3 > >>>> > >>>>> FYI ... I am still seeing a build failure because of this with -rc2 ... > >>>> > >>>> Can you see if -rc3 is also giving you problems? > >>> > >>> Better, but I appear to be seeing some random suspend failures with this > >>> now on one board. I will try to bisect this. > >>> > >>> Test results for stable-v4.4: > >>> 6 builds: 6 pass, 0 fail > >>> 12 boots: 12 pass, 0 fail > >>> 19 tests: 18 pass, 1 fail > >>> > >>> Linux version: 4.4.203-rc3-g2576206c30b5 > >>> Boards tested: tegra124-jetson-tk1, tegra20-ventana, > >>> tegra30-cardhu-a04 > >> > >> Odd. If you find anything interesting, please let me know. > > > > Yes will do. Bisect has not found anything yet, so will keeping looking > > to see if this is a false-positive or not. > > I have been doing some more testing and it appears that I see > intermittent suspend failures on Tegra124 with linux-4.4.y. Apparently > this issue has always been there and appears to be fixed in v4.5. I am > still trying to find a way to fix this. The changes in v4.5 that appear > to resolve this are too complex for stable (several patches in Tegra clk > drivers). Anyway, ignore this for now, I will see how we can fix or > workaround for linux-4.4.y. Ok, thanks for letting us know and good luck with it. greg k-h