From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72E1FC432C0 for ; Thu, 28 Nov 2019 13:41:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4A2BC2176D for ; Thu, 28 Nov 2019 13:41:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574948517; bh=4W5lmUp57I07jpiDCIQgF2mFUZ4tOl3slL+ewf40+fo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=HXn1KgVHj1iry96sND84C29fPA2ySYy8b81XFDwLBylSe3qGfPTC+BuAeXPFK0Amn PzNjD8sh+F5y9+EmCOL6oXfscCZ8akQ+U2xUjcTe2sgTbv9NT3dqNsG1XP1ILpgaLz KqXiPtSwNBw2g6PstGaOTh9fdMUaTkfAm66h+ORM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727345AbfK1Nlg (ORCPT ); Thu, 28 Nov 2019 08:41:36 -0500 Received: from mail.kernel.org ([198.145.29.99]:37998 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727289AbfK1Nl1 (ORCPT ); Thu, 28 Nov 2019 08:41:27 -0500 Received: from quaco.ghostprotocols.net (unknown [179.97.35.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EEA8F21789; Thu, 28 Nov 2019 13:41:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574948487; bh=4W5lmUp57I07jpiDCIQgF2mFUZ4tOl3slL+ewf40+fo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MxIeuZjYoaB1X5BJnoQKpZ1lyOScUHrAbskKGqlS6XRO0XycAXjFkZjYQTe9RmwuC EPNDjHYaLLC1OlGnyG0TPovBVw1vDR05vJoTJEQwFVVeimDanX6suAgKjv0zPL5COq 1CfAqO8Kve2dcTkqQn+S+Rbw7Vz00vt9VkHP8UFY= From: Arnaldo Carvalho de Melo To: Ingo Molnar , Thomas Gleixner Cc: Jiri Olsa , Namhyung Kim , Clark Williams , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Arnaldo Carvalho de Melo , Jin Yao , Adrian Hunter Subject: [PATCH 16/22] perf diff: Use llabs() with 64-bit values Date: Thu, 28 Nov 2019 10:40:21 -0300 Message-Id: <20191128134027.23726-17-acme@kernel.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20191128134027.23726-1-acme@kernel.org> References: <20191128134027.23726-1-acme@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnaldo Carvalho de Melo To fix these build errors on a debian mipsel cross build environment: builtin-diff.c: In function 'block_cycles_diff_cmp': builtin-diff.c:550:6: error: absolute value function 'labs' given an argument of type 's64' {aka 'long long int'} but has parameter of type 'long int' which may cause truncation of value [-Werror=absolute-value] 550 | l = labs(left->diff.cycles); | ^~~~ builtin-diff.c:551:6: error: absolute value function 'labs' given an argument of type 's64' {aka 'long long int'} but has parameter of type 'long int' which may cause truncation of value [-Werror=absolute-value] 551 | r = labs(right->diff.cycles); | ^~~~ Fixes: 99150a1faab2 ("perf diff: Use hists to manage basic blocks per symbol") Cc: Jin Yao Cc: Adrian Hunter Cc: Jiri Olsa Cc: Namhyung Kim Link: https://lkml.kernel.org/n/tip-pn7szy5uw384ntjgk6zckh6a@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/builtin-diff.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/perf/builtin-diff.c b/tools/perf/builtin-diff.c index 376dbf10ad64..eae879376283 100644 --- a/tools/perf/builtin-diff.c +++ b/tools/perf/builtin-diff.c @@ -547,8 +547,8 @@ static int64_t block_cycles_diff_cmp(struct hist_entry *left, if (!pairs_left && !pairs_right) return 0; - l = labs(left->diff.cycles); - r = labs(right->diff.cycles); + l = llabs(left->diff.cycles); + r = llabs(right->diff.cycles); return r - l; } -- 2.21.0