From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AC1BC432C0 for ; Thu, 28 Nov 2019 13:41:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 21E482176D for ; Thu, 28 Nov 2019 13:41:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574948519; bh=mH9g3Vifsixa+l0k7MuRbmDzt21UQM0uIs3jyCd0deI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=1Z7ieOM1S/FtAq8SJtA3DoJ3pdHBODGlyTJf1Tt5wSXm+n37bHmSBdMg9Xb/mVL8v D69LkoKXtS6HvFbcRnWoh/oRBARdHpzt7J+IoCVvoqOzACdVOpPLoerAWoP9DJuOUk 5PbVOiROHaQItYEb0eo/kytT1k3qtq8QugWo1CEA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727327AbfK1Nld (ORCPT ); Thu, 28 Nov 2019 08:41:33 -0500 Received: from mail.kernel.org ([198.145.29.99]:38056 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727263AbfK1Nlb (ORCPT ); Thu, 28 Nov 2019 08:41:31 -0500 Received: from quaco.ghostprotocols.net (unknown [179.97.35.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DD21221787; Thu, 28 Nov 2019 13:41:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574948490; bh=mH9g3Vifsixa+l0k7MuRbmDzt21UQM0uIs3jyCd0deI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZnLsyTtZvMOtXvmAN2COKymtXOWWDOc34PN5P6vDsmQcWR/ZfM8qmzhNR64UTuCyv N8Io1iFWC3/exUhYAZ+KCqJHSPrUlaebdXWPOX6Q4krIuDvqlL12WyS0hO8UzxZB6W ksdVANCmOcVSiNIeGnc0cvAPx+BxjD588dX8sW5Y= From: Arnaldo Carvalho de Melo To: Ingo Molnar , Thomas Gleixner Cc: Jiri Olsa , Namhyung Kim , Clark Williams , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Arnaldo Carvalho de Melo , Jin Yao , Adrian Hunter Subject: [PATCH 17/22] perf diff: Use llabs() with 64-bit values Date: Thu, 28 Nov 2019 10:40:22 -0300 Message-Id: <20191128134027.23726-18-acme@kernel.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20191128134027.23726-1-acme@kernel.org> References: <20191128134027.23726-1-acme@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnaldo Carvalho de Melo To fix this build error on a debian mipsel cross build environment: builtin-diff.c: In function 'compute_cycles_diff': builtin-diff.c:649:10: error: absolute value function 'labs' given an argument of type 's64' {aka 'long long int'} but has parameter of type 'long int' which may cause truncation of value [-Werror=absolute-value] 649 | val = labs(pair->block_info->cycles_spark[i] - | ^~~~ Fixes: cebf7d51a6c3 ("perf diff: Report noisy for cycles diff") Cc: Jin Yao Cc: Adrian Hunter Cc: Jiri Olsa Cc: Namhyung Kim Link: https://lkml.kernel.org/n/tip-pn7szy5uw384ntjgk6zckh6a@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/builtin-diff.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/builtin-diff.c b/tools/perf/builtin-diff.c index eae879376283..f8b6ae557d8b 100644 --- a/tools/perf/builtin-diff.c +++ b/tools/perf/builtin-diff.c @@ -646,7 +646,7 @@ static void compute_cycles_diff(struct hist_entry *he, if (i >= he->block_info->num || i >= NUM_SPARKS) break; - val = labs(pair->block_info->cycles_spark[i] - + val = llabs(pair->block_info->cycles_spark[i] - he->block_info->cycles_spark[i]); update_spark_value(pair->diff.svals, NUM_SPARKS, -- 2.21.0