From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PULL_REQUEST, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D548EC432C0 for ; Fri, 29 Nov 2019 23:22:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9E66A215A5 for ; Fri, 29 Nov 2019 23:22:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="FRPpk2ee" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727187AbfK2XW6 (ORCPT ); Fri, 29 Nov 2019 18:22:58 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:58576 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727117AbfK2XW6 (ORCPT ); Fri, 29 Nov 2019 18:22:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575069777; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=w/RpwCzNh4T96NxmvHCH93XlY1vnmOQTw+xJ5ycGdZ4=; b=FRPpk2ee19+TCtSXfUv/lS9qvLNW7+e2gsauazE4IzJKFG9zRO9pdkwzLTFrMD46IECslo 0azGBjDinyNLLA79jOU5Yodiu4egHRWTbVcUUp3uEfqJNjEbvOHeEmnUMI/RxevGZe04ln KpzUROLfa08GqnYZFm/eO/doa9a2vjk= Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-436-qWFZHyGvMrui_wGrcyhXuQ-1; Fri, 29 Nov 2019 18:22:53 -0500 Received: by mail-pj1-f72.google.com with SMTP id ce9so15473662pjb.22 for ; Fri, 29 Nov 2019 15:22:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:reply-to :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=ZCU10GLMp0nmlpxoMd1rrdxCmZnADUD6Dp0yLrZ6PZg=; b=a4cK8Bz9GLIaEY7MNPHP2uT3KkUoAyWGY9N9x+CagbhLMbupdiZ1y19L1exjzS1BDa PHorh4DpsClk1oCL1uHsTkrfh6ZMPH1c64jbN6z4//gf4RYsMZZv4fz+Ue7nHXYt2dc6 M2DrmwUOVKJxn2ecy0TAnsQ5mCMrU5Z1PuMquPvE0e9rWSVECPesF3ugQAXW2ke6/88m k0FOTQfcosAZTtDSk6uGlPVq2CSNfWRBcZE9iz78Cd+GX4nxrqgx0Hxs2JrDqs6q40qA IOCVLGjllL+yE1hQPX2/hR8UBRwiBk6LrhtNyZ/qtvX6wh7FRNxXFGsfd/eRDubA0EZ5 j5wA== X-Gm-Message-State: APjAAAWr3sn+wJzElXWM2Pe+jS2v1wA+m42uUcwpPwscuUZoEKsjfdVM 3duKi3Cd01EXkCnZv1q/OCuIRQfJ8uK2TTdnE7snzTyJWne62ZJIqo8bTVDMKst3GzqyGwu0lYL qkFXSyQHrJVb60ah+IVz21AX/ X-Received: by 2002:a63:b20f:: with SMTP id x15mr19034127pge.65.1575069772182; Fri, 29 Nov 2019 15:22:52 -0800 (PST) X-Google-Smtp-Source: APXvYqwD3MAI8bq8P3FB6H1A/8gtWkn30hL/Lcnp5oIIn/ZxXBjtDU5P/tIKPfK4rXldIPzwqX0YVQ== X-Received: by 2002:a63:b20f:: with SMTP id x15mr19034105pge.65.1575069771753; Fri, 29 Nov 2019 15:22:51 -0800 (PST) Received: from localhost (ip70-163-223-149.ph.ph.cox.net. [70.163.223.149]) by smtp.gmail.com with ESMTPSA id 64sm26345151pfe.147.2019.11.29.15.22.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Nov 2019 15:22:50 -0800 (PST) Date: Fri, 29 Nov 2019 16:22:49 -0700 From: Jerry Snitselaar To: Jarkko Sakkinen Cc: Dan Williams , Linus Torvalds , Linux Kernel Mailing List , linux-integrity@vger.kernel.org, James Morris , Stefan Berger , stable Subject: Re: [GIT PULL] tpmdd updates for Linux v5.4 Message-ID: <20191129232249.bgj25rlwrcg3afj5@cantor> Reply-To: Jerry Snitselaar Mail-Followup-To: Jarkko Sakkinen , Dan Williams , Linus Torvalds , Linux Kernel Mailing List , linux-integrity@vger.kernel.org, James Morris , Stefan Berger , stable References: <20190902143121.pjnykevzlajlcrh6@linux.intel.com> <20191122161836.ry3cbon2iy22ftoc@cantor> <20191129210400.GB12055@linux.intel.com> MIME-Version: 1.0 In-Reply-To: <20191129210400.GB12055@linux.intel.com> X-MC-Unique: qWFZHyGvMrui_wGrcyhXuQ-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri Nov 29 19, Jarkko Sakkinen wrote: >On Fri, Nov 22, 2019 at 09:18:36AM -0700, Jerry Snitselaar wrote: >> On Wed Nov 20 19, Dan Williams wrote: >> > On Mon, Sep 2, 2019 at 7:34 AM Jarkko Sakkinen >> > wrote: >> > > >> > > Hi >> > > >> > > A new driver for fTPM living inside ARM TEE was added this round. In >> > > addition to that, there is three bug fixes and one clean up. >> > > >> > > /Jarkko >> > > >> > > The following changes since commit 8fb8e9e46261e0117cb3cffb6dd8bb7e0= 8f8649b: >> > > >> > > Merge tag 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel= /git/rdma/rdma (2019-08-30 09:23:45 -0700) >> > > >> > > are available in the Git repository at: >> > > >> > > git://git.infradead.org/users/jjs/linux-tpmdd.git tags/tpmdd-next-= 20190902 >> > > >> > > for you to fetch changes up to e8bd417aab0c72bfb54465596b16085702ba0= 405: >> > > >> > > tpm/tpm_ftpm_tee: Document fTPM TEE driver (2019-09-02 17:08:35 +0= 300) >> > > >> > > ---------------------------------------------------------------- >> > > tpmdd updates for Linux v5.4 >> > > >> > > ---------------------------------------------------------------- >> > > Jarkko Sakkinen (1): >> > > tpm: Remove a deprecated comments about implicit sysfs locking >> > > >> > > Lukas Bulwahn (1): >> > > MAINTAINERS: fix style in KEYS-TRUSTED entry >> > > >> > > Sasha Levin (2): >> > > tpm/tpm_ftpm_tee: A driver for firmware TPM running inside TEE >> > > tpm/tpm_ftpm_tee: Document fTPM TEE driver >> > > >> > > Stefan Berger (2): >> > > tpm_tis_core: Turn on the TPM before probing IRQ's >> > > tpm_tis_core: Set TPM_CHIP_FLAG_IRQ before probing for interru= pts >> > >> > Hi Jarrko, >> > >> > I'm replying here because I can't find the patches to reply to >> > directly from LKML. >> > >> > Commit 7f064c378e2c "tpm_tis_core: Turn on the TPM before probing >> > IRQ's" in the v5.3-stable tree caused a regression on a pre-release >> > platform with a TPM2 device. The interrupt starts screaming when the >> > driver is loaded and does not stop until the device is force unbond >> > from the driver by: >> > >> > echo IFX0740:00 > /sys/bus/platform/drivers/tpm_tis/unbind >> > >> > I checked v5.4-rc8 and it has the same problem. I tried reverting: >> > >> > 1ea32c83c699 tpm_tis_core: Set TPM_CHIP_FLAG_IRQ before probing for in= terrupts >> > 5b359c7c4372 tpm_tis_core: Turn on the TPM before probing IRQ's >> > >> > Which silenced the screaming interrupt problem, but now the TPM is rep= orting: >> > >> > [ 3.725131] tpm_tis IFX0740:00: 2.0 TPM (device-id 0x1B, rev-id 16) >> > [ 3.725358] tpm tpm0: tpm_try_transmit: send(): error -5 >> > [ 3.725359] tpm tpm0: [Firmware Bug]: TPM interrupt not working, >> > polling instead >> > >> > ...at load, where it was not reporting this previously. Can you take a= look? >> > >> >> We've had an issue reported for a Lenovo t490s getting an interrupt stor= m >> with the Fedora 5.3 stable kernel, so it appears to be impacting a numbe= r of >> systems. > >Hi sorry for inactivity. I've had a renovation going on where I live >which has caused some crackling in the comms but I'm catching up during >the weekend. > >Which CPU model does T490S have? Can you paste /proc/cpuinfo? > >/Jarkko > I still don't have access to one of the laptops, but looking online they should have one of the following: i5-8265U, i5-8365U, i7-8565U, or i7-8665U. The tpm is discrete, so I don't know that the cpu will matter. Looking at a log, in the t490s case it is an STMicroelectronics chip. So both Infineon and STM so far.