From: Peter Zijlstra <peterz@infradead.org>
To: Shile Zhang <shile.zhang@linux.alibaba.com>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Michal Marek <michal.lkml@markovi.net>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Andy Lutomirski <luto@amacapital.net>,
x86@kernel.org, "H . Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org
Subject: Re: [RFC PATCH v5 0/7] Speed booting by sorting ORC unwind tables at build time
Date: Mon, 2 Dec 2019 11:32:48 +0100 [thread overview]
Message-ID: <20191202103248.GB2827@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20191128110206.2107-1-shile.zhang@linux.alibaba.com>
On Thu, Nov 28, 2019 at 07:01:59PM +0800, Shile Zhang wrote:
> This series refactored the original sortextable tools, add ORC unwind
> tables sort at build time.
>
> To sort the ORC unwind tables(.orc_unwind & .orc_unwind_ip) can save
> about 100ms in my test ENV (2C4G VM w/ Xeon 2.5GHz CPU).
> It costs about 30ms sort by new sorttable tool.
IIRC from your previous emails the new build-time sort is actually
shorter than that, so even for single build+run scenarios we win.
The code looks good to me, so:
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Who it going to apply this? I suppose we could take it through -tip,
like we do with all x86 and objtool related bits.
next prev parent reply other threads:[~2019-12-02 10:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-28 11:01 Shile Zhang
2019-11-28 11:02 ` [RFC PATCH v5 1/7] scripts/sortextable: Rewrite error/success handling Shile Zhang
2019-11-28 11:02 ` [RFC PATCH v5 2/7] scripts/sortextable: kernel coding style formating Shile Zhang
2019-11-28 11:02 ` [RFC PATCH v5 3/7] scripts/sortextable: Remove dead code Shile Zhang
2019-11-28 11:02 ` [RFC PATCH v5 4/7] scripts/sortextable: refactor do_func() function Shile Zhang
2019-11-28 11:02 ` [RFC PATCH v5 5/7] scripts/sorttable: rename sortextable to sorttable Shile Zhang
2019-11-28 11:02 ` [RFC PATCH v5 6/7] scripts/sorttable: Add ORC unwind tables sort concurrently Shile Zhang
2019-11-28 11:02 ` [RFC PATCH v5 7/7] x86/unwind/orc: remove run-time ORC unwind tables sort Shile Zhang
2019-12-02 10:32 ` Peter Zijlstra [this message]
2019-12-02 12:10 ` [RFC PATCH v5 0/7] Speed booting by sorting ORC unwind tables at build time Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191202103248.GB2827@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=michal.lkml@markovi.net \
--cc=mingo@redhat.com \
--cc=shile.zhang@linux.alibaba.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®