mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Fenghua Yu <fenghua.yu@intel.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, H Peter Anvin <hpa@zytor.com>,
	Tony Luck <tony.luck@intel.com>,
	Reinette Chatre <reinette.chatre@intel.com>,
	Babu Moger <babu.moger@amd.com>,
	Andre Przywara <Andre.Przywara@arm.com>,
	Sai Praneeth Prakhya <sai.praneeth.prakhya@intel.com>,
	Ravi V Shankar <ravi.v.shankar@intel.com>,
	linux-kernel <linux-kernel@vger.kernel.org>, x86 <x86@kernel.org>
Subject: Re: [PATCH v8 01/13] selftests/resctrl: Add README for resctrl tests
Date: Mon, 2 Dec 2019 15:42:44 -0800	[thread overview]
Message-ID: <20191202234244.GC220960@romley-ivt3.sc.intel.com> (raw)
In-Reply-To: <20191202230642.GD32696@zn.tnic>

On Tue, Dec 03, 2019 at 12:06:42AM +0100, Borislav Petkov wrote:
> On Mon, Dec 02, 2019 at 10:53:35AM -0800, Fenghua Yu wrote:
> > Babu's major contributions are in v5 where he virtually touched every
> > patch. He sent out v5 and put Signed-off-by: Babu Moger in each patch:
> > https://lore.kernel.org/patchwork/cover/1033532/
> > 
> > That's why I keep his SOB in v6-v8 in each patch.
> 
> For that you either need to use
> 
> Co-developed-by: Babu
> 
> or state the fact that Babu did contribute to the patches in freetext in
> the commit messages.
> 
> As it is now, it is not clear what it means. You could've kept the order
> from v5 since you took his submission and could've done:
> 
> Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
> Signed-off-by: Babu Moger <babu.moger@amd.com>
> Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
> 
> to show you're the author, Babu handled them further and you're sending
> the patchset now, but the other thing I suggested above is more clear
> IMO.

Ok. I will add Co-developed-by: Babu in the patches.

Should I send v9 patch set with only the Co-developed-by changes?

Thanks.

-Fenghua

  reply	other threads:[~2019-12-02 23:30 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-28  0:39 [PATCH v8 00/13] selftests/resctrl: Add resctrl selftest Fenghua Yu
2019-11-28  0:39 ` [PATCH v8 01/13] selftests/resctrl: Add README for resctrl tests Fenghua Yu
2019-11-28  7:23   ` Borislav Petkov
2019-12-02 18:53     ` Fenghua Yu
2019-12-02 23:06       ` Borislav Petkov
2019-12-02 23:42         ` Fenghua Yu [this message]
2019-12-02 23:49           ` Borislav Petkov
2019-12-03  0:04             ` Fenghua Yu
2019-11-28  0:39 ` [PATCH v8 02/13] selftests/resctrl: Add basic resctrl file system operations and data Fenghua Yu
2019-11-28  0:39 ` [PATCH v8 03/13] selftests/resctrl: Read memory bandwidth from perf IMC counter and from resctrl file system Fenghua Yu
2019-11-28  0:39 ` [PATCH v8 04/13] selftests/resctrl: Add callback to start a benchmark Fenghua Yu
2019-11-28  0:39 ` [PATCH v8 05/13] selftests/resctrl: Add built in benchmark Fenghua Yu
2019-11-28  0:39 ` [PATCH v8 06/13] selftests/resctrl: Add MBM test Fenghua Yu
2019-11-28  0:39 ` [PATCH v8 07/13] selftests/resctrl: Add MBA test Fenghua Yu
2019-11-28  0:39 ` [PATCH v8 08/13] selftests/resctrl: Add Cache QoS Monitoring (CQM) selftest Fenghua Yu
2019-11-28  0:39 ` [PATCH v8 09/13] selftests/resctrl: Add Cache Allocation Technology (CAT) selftest Fenghua Yu
2019-11-28  0:39 ` [PATCH v8 10/13] selftests/resctrl: Add vendor detection mechanism Fenghua Yu
2019-11-28  0:39 ` [PATCH v8 11/13] selftests/resctrl: Use cache index3 id for AMD schemata masks Fenghua Yu
2019-11-28  0:39 ` [PATCH v8 12/13] selftests/resctrl: Disable MBA and MBM tests for AMD Fenghua Yu
2019-11-28  0:39 ` [PATCH v8 13/13] selftests/resctrl: Add the test in MAINTAINERS Fenghua Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191202234244.GC220960@romley-ivt3.sc.intel.com \
    --to=fenghua.yu@intel.com \
    --cc=Andre.Przywara@arm.com \
    --cc=babu.moger@amd.com \
    --cc=bp@alien8.de \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=ravi.v.shankar@intel.com \
    --cc=reinette.chatre@intel.com \
    --cc=sai.praneeth.prakhya@intel.com \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®