From: Valentin Schneider <valentin.schneider@arm.com>
To: linux-kernel@vger.kernel.org
Cc: peterz@infradead.org, mingo@kernel.org,
vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
patrick.bellasi@matbug.net, qperret@google.com,
qais.yousef@arm.com, morten.rasmussen@arm.com
Subject: [PATCH v2 2/4] sched/uclamp: Rename uclamp_util_*() into uclamp_rq_util_*()
Date: Tue, 3 Dec 2019 15:59:05 +0000 [thread overview]
Message-ID: <20191203155907.2086-3-valentin.schneider@arm.com> (raw)
In-Reply-To: <20191203155907.2086-1-valentin.schneider@arm.com>
The current helpers return (CPU) rq utilization with uclamp restrictions
taken into account. As I'm about to introduce a task clamped utilization
variant, make it explicit that those deal with runqueues.
Reviewed-by: Quentin Perret <qperret@google.com>
Signed-off-by: Valentin Schneider <valentin.schneider@arm.com>
---
kernel/sched/cpufreq_schedutil.c | 2 +-
kernel/sched/sched.h | 14 +++++++-------
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/kernel/sched/cpufreq_schedutil.c b/kernel/sched/cpufreq_schedutil.c
index 86800b4d5453..9deb3a13416d 100644
--- a/kernel/sched/cpufreq_schedutil.c
+++ b/kernel/sched/cpufreq_schedutil.c
@@ -240,7 +240,7 @@ unsigned long schedutil_cpu_util(int cpu, unsigned long util_cfs,
*/
util = util_cfs + cpu_util_rt(rq);
if (type == FREQUENCY_UTIL)
- util = uclamp_util_with(rq, util, p);
+ util = uclamp_rq_util_with(rq, util, p);
dl_util = cpu_util_dl(rq);
diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
index f1d035e5df7e..900328c4eeef 100644
--- a/kernel/sched/sched.h
+++ b/kernel/sched/sched.h
@@ -2303,8 +2303,8 @@ static inline void cpufreq_update_util(struct rq *rq, unsigned int flags) {}
unsigned int uclamp_eff_value(struct task_struct *p, enum uclamp_id clamp_id);
static __always_inline
-unsigned long uclamp_util_with(struct rq *rq, unsigned long util,
- struct task_struct *p)
+unsigned long uclamp_rq_util_with(struct rq *rq, unsigned long util,
+ struct task_struct *p)
{
unsigned long min_util = READ_ONCE(rq->uclamp[UCLAMP_MIN].value);
unsigned long max_util = READ_ONCE(rq->uclamp[UCLAMP_MAX].value);
@@ -2325,17 +2325,17 @@ unsigned long uclamp_util_with(struct rq *rq, unsigned long util,
return clamp(util, min_util, max_util);
}
-static inline unsigned long uclamp_util(struct rq *rq, unsigned long util)
+static inline unsigned long uclamp_rq_util(struct rq *rq, unsigned long util)
{
- return uclamp_util_with(rq, util, NULL);
+ return uclamp_rq_util_with(rq, util, NULL);
}
#else /* CONFIG_UCLAMP_TASK */
-static inline unsigned long uclamp_util_with(struct rq *rq, unsigned long util,
- struct task_struct *p)
+static inline unsigned long uclamp_rq_util_with(struct rq *rq, unsigned long util,
+ struct task_struct *p)
{
return util;
}
-static inline unsigned long uclamp_util(struct rq *rq, unsigned long util)
+static inline unsigned long uclamp_rq_util(struct rq *rq, unsigned long util)
{
return util;
}
--
2.24.0
next prev parent reply other threads:[~2019-12-03 16:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-03 15:59 [PATCH v2 0/4] sched/fair: Task placement biasing using uclamp Valentin Schneider
2019-12-03 15:59 ` [PATCH v2 1/4] sched/uclamp: Make uclamp_util_*() helpers use and return UL values Valentin Schneider
2019-12-04 15:22 ` Vincent Guittot
2019-12-04 16:03 ` Valentin Schneider
2019-12-04 16:12 ` Vincent Guittot
2019-12-04 16:25 ` Rainer Sickinger
2019-12-04 17:15 ` Valentin Schneider
2019-12-04 17:29 ` Vincent Guittot
2019-12-04 17:35 ` Valentin Schneider
2019-12-10 18:09 ` Dietmar Eggemann
2019-12-10 18:31 ` Valentin Schneider
2019-12-03 15:59 ` Valentin Schneider [this message]
2019-12-03 15:59 ` [PATCH v2 3/4] sched/fair: Make task_fits_capacity() consider uclamp restrictions Valentin Schneider
2019-12-10 17:07 ` Dietmar Eggemann
2019-12-10 17:10 ` Valentin Schneider
2019-12-03 15:59 ` [PATCH v2 4/4] sched/fair: Make feec() " Valentin Schneider
2019-12-10 18:23 ` Dietmar Eggemann
2019-12-10 18:35 ` Valentin Schneider
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191203155907.2086-3-valentin.schneider@arm.com \
--to=valentin.schneider@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=morten.rasmussen@arm.com \
--cc=patrick.bellasi@matbug.net \
--cc=peterz@infradead.org \
--cc=qais.yousef@arm.com \
--cc=qperret@google.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®