From: Peter Zijlstra <peterz@infradead.org>
To: "Liang, Kan" <kan.liang@linux.intel.com>
Cc: mingo@redhat.com, acme@kernel.org, tglx@linutronix.de,
bp@alien8.de, linux-kernel@vger.kernel.org, eranian@google.com,
alexey.budankov@linux.intel.com, vitaly.slobodskoy@intel.com,
ak@linux.intel.com
Subject: Re: [RFC PATCH 2/8] perf: Helpers for alloc/init/fini PMU specific data
Date: Wed, 4 Dec 2019 13:36:56 +0100 [thread overview]
Message-ID: <20191204123656.GU2844@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <2d036aa5-542a-8c01-762c-3b68136887f5@linux.intel.com>
On Mon, Dec 02, 2019 at 03:35:00PM -0500, Liang, Kan wrote:
> Could you please give me an example?
There's a ton of refcounting in perf, none of it follows this pattern.
> I think we do need something to protect the refcount. Are you suggesting
> atomic_*?
refcount_t comes to mind.
next prev parent reply other threads:[~2019-12-04 12:37 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-28 15:14 [RFC PATCH 1/8] perf: Save PMU specific data in task_struct kan.liang
2019-11-28 15:14 ` [RFC PATCH 2/8] perf: Helpers for alloc/init/fini PMU specific data kan.liang
2019-12-02 13:16 ` Peter Zijlstra
2019-12-02 15:25 ` Alexey Budankov
2019-12-02 20:35 ` Liang, Kan
2019-12-04 12:36 ` Peter Zijlstra [this message]
2019-11-28 15:14 ` [RFC PATCH 3/8] perf: Init/fini " kan.liang
2019-12-02 12:40 ` Peter Zijlstra
2019-12-02 14:59 ` Andi Kleen
2019-12-02 16:21 ` Peter Zijlstra
2019-12-02 19:15 ` Andi Kleen
2019-12-02 20:13 ` Liang, Kan
2019-12-02 20:25 ` Andi Kleen
2019-12-02 20:44 ` Liang, Kan
2019-12-04 13:12 ` Peter Zijlstra
2019-12-02 16:38 ` Alexey Budankov
2019-12-02 16:43 ` Peter Zijlstra
2019-12-02 17:42 ` Alexey Budankov
2019-11-28 15:14 ` [RFC PATCH 4/8] perf: Supply task information to sched_task() kan.liang
2019-11-28 15:14 ` [RFC PATCH 5/8] perf/x86/lbr: Fix shorter LBRs call stacks for system-wide mode kan.liang
2019-11-28 15:14 ` [RFC PATCH 6/8] perf/x86: Remove swap_task_ctx() kan.liang
2019-11-28 15:14 ` [RFC PATCH 7/8] perf: Clean up pmu specific data kan.liang
2019-11-28 15:14 ` [RFC PATCH 8/8] perf: Clean up event context from sched_task() kan.liang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191204123656.GU2844@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexey.budankov@linux.intel.com \
--cc=bp@alien8.de \
--cc=eranian@google.com \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=vitaly.slobodskoy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome