From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9C23C2BBE2 for ; Fri, 6 Dec 2019 16:34:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8FD9120659 for ; Fri, 6 Dec 2019 16:34:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575650046; bh=FwQ6VscWsqMam9RlefGeqZZTmrK5VLbts/8e96NHtDs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=vVFNoHJKt0J+Y99Q1lAMNdObb0JJgjNNHbHdThxAjlFVap9jGKgswDynpgYxMWLo2 Vz1AppHKSz+9dkrSeFr7hN6OnHGwKW3YfYwG3LEgjxhGNchMpr5xwbXXzJSUMHcVL7 F6BK1BBPR9bAj2IlZ4L3SOL1ccc74HS3CiwwJY9E= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726796AbfLFQeC (ORCPT ); Fri, 6 Dec 2019 11:34:02 -0500 Received: from mail.kernel.org ([198.145.29.99]:43360 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726400AbfLFQeB (ORCPT ); Fri, 6 Dec 2019 11:34:01 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 92B3B20659; Fri, 6 Dec 2019 16:34:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575650041; bh=FwQ6VscWsqMam9RlefGeqZZTmrK5VLbts/8e96NHtDs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CToJK3TfBlAqQ5tLy/hzDY80uIkNeEM9nJPTjtUgEOjLxPbJ85Qajp/UVxSF54EXc RE2MOUm0obEjPwfo2DqqyxhJsQvv2pdtxhYXJXwg0IsS9VXOWN5d+NMcc7Mz7itNyM EIWlfHOPdtOpzMsfhZitLXWQa15aD1euwwqoeqZc= Date: Fri, 6 Dec 2019 17:33:58 +0100 From: Greg KH To: Thomas Renninger Cc: linux-kernel@vger.kernel.org, Felix Schnizlein , linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux@armlinux.org.uk, will.deacon@arm.com, x86@kernel.org, fschnitzlein@suse.de, Felix Schnizlein Subject: Re: [PATCH 1/3] cpuinfo: add sysfs based arch independent cpuinfo framework Message-ID: <20191206163358.GB86904@kroah.com> References: <20191206162421.15050-1-trenn@suse.de> <20191206162421.15050-2-trenn@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191206162421.15050-2-trenn@suse.de> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 06, 2019 at 05:24:19PM +0100, Thomas Renninger wrote: > --- /dev/null > +++ b/drivers/base/cpuinfo.c > @@ -0,0 +1,48 @@ > +/* > + * Copyright (C) 2017 SUSE Linux GmbH > + * Written by: Felix Schnizlein > + * > + * This program is free software; you can redistribute it and/or > + * modify it under the terms of the GNU General Public License version > + * 2 as published by the Free Software Foundation. > + * > + * This program is distributed in the hope that it will be useful, but > + * WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * General Public License for more details. > + * > + */ No SPDX line? And you can drop the license boilerplate text as well too. > + > +#include > +#include > +#include > + > +static struct attribute_group cpuinfo_attr_group = { > + .attrs = cpuinfo_attrs, > + .name = "info" > +}; > + > +static int cpuinfo_add_dev(unsigned int cpu) > +{ > + struct device *dev = get_cpu_device(cpu); > + > + return sysfs_create_group(&dev->kobj, &cpuinfo_attr_group); Why are a set of attributes being added _after_ the device is created? We have fixed up a lot of the "default attribute" logic since 2017, perhaps you should be using that instead? > +} > + > +static int cpuinfo_remove_dev(unsigned int cpu) > +{ > + struct device *dev = get_cpu_device(cpu); > + > + sysfs_remove_group(&dev->kobj, &cpuinfo_attr_group); Same here, I don't think this is needed. > + return 0; > +} > + > +static int cpuinfo_sysfs_init(void) > +{ > + return cpuhp_setup_state(CPUHP_CPUINFO_PREPARE, > + "base/cpuinfo:prepare", > + cpuinfo_add_dev, > + cpuinfo_remove_dev); > +} > + > +device_initcall(cpuinfo_sysfs_init); > diff --git a/include/linux/cpuhotplug.h b/include/linux/cpuhotplug.h > index e51ee772b9f5..2c4c59304bdb 100644 > --- a/include/linux/cpuhotplug.h > +++ b/include/linux/cpuhotplug.h > @@ -78,6 +78,7 @@ enum cpuhp_state { > CPUHP_SH_SH3X_PREPARE, > CPUHP_NET_FLOW_PREPARE, > CPUHP_TOPOLOGY_PREPARE, > + CPUHP_CPUINFO_PREPARE, > CPUHP_NET_IUCV_PREPARE, > CPUHP_ARM_BL_PREPARE, > CPUHP_TRACE_RB_PREPARE, > diff --git a/include/linux/cpuinfo.h b/include/linux/cpuinfo.h > new file mode 100644 > index 000000000000..112ff76d64d5 > --- /dev/null > +++ b/include/linux/cpuinfo.h > @@ -0,0 +1,43 @@ > +/* > + * Copyright (C) 2017 SUSE Linux GmbH > + * Written by: Felix Schnizlein > + * > + * This program is free software; you can redistribute it and/or > + * modify it under the terms of the GNU General Public License version > + * 2 as published by the Free Software Foundation. > + * > + * This program is distributed in the hope that it will be useful, but > + * WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * General Public License for more details. SPDX and boilerplate. > + */ > +#ifndef _LINUX_CPUINFO_H > +#define _LINUX_CPUINFO_H > + > +#ifdef CONFIG_HAVE_CPUINFO_SYSFS > +extern struct attribute *cpuinfo_attrs[]; No need for thie #ifdef really, right? thanks, greg k-h