From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DC00C43603 for ; Sat, 7 Dec 2019 19:57:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 461EC21835 for ; Sat, 7 Dec 2019 19:57:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726796AbfLGT5N (ORCPT ); Sat, 7 Dec 2019 14:57:13 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:42802 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726489AbfLGT5N (ORCPT ); Sat, 7 Dec 2019 14:57:13 -0500 Received: from localhost (unknown [IPv6:2601:601:9f00:1c3::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 63B1015421AE9; Sat, 7 Dec 2019 11:57:12 -0800 (PST) Date: Sat, 07 Dec 2019 11:57:12 -0800 (PST) Message-Id: <20191207.115712.355931673337702807.davem@davemloft.net> To: grygorii.strashko@ti.com Cc: netdev@vger.kernel.org, nsekhar@ti.com, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org Subject: Re: [PATCH v2] net: ethernet: ti: cpsw: fix extra rx interrupt From: David Miller In-Reply-To: <20191206122820.24811-1-grygorii.strashko@ti.com> References: <20191206122820.24811-1-grygorii.strashko@ti.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 07 Dec 2019 11:57:12 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Grygorii Strashko Date: Fri, 6 Dec 2019 14:28:20 +0200 > Now RX interrupt is triggered twice every time, because in > cpsw_rx_interrupt() it is asked first and then disabled. So there will be > pending interrupt always, when RX interrupt is enabled again in NAPI > handler. > > Fix it by first disabling IRQ and then do ask. > > Fixes: 870915feabdc ("drivers: net: cpsw: remove disable_irq/enable_irq as irq can be masked from cpsw itself") > Signed-off-by: Grygorii Strashko Applied and queued up for -stable.