From: Dave Wang <dave.wang@emc.com.tw>
To: Linux-input@vger.kernel.org, Linux-kernel@vger.kernel.org,
Dmitry.torokhov@gmail.com
Cc: phoenix@emc.com.tw, josh.chen@emc.com.tw, jingle.wu@emc.com.tw,
kai.heng.feng@canonical.com, Dave Wang <dave.wang@emc.com.tw>
Subject: [PATCH 2/3] Input: elan_i2c - Do no operation for elan_smbus_sleep_control function
Date: Mon, 9 Dec 2019 06:14:29 -0500 [thread overview]
Message-ID: <20191209111429.32315-1-dave.wang@emc.com.tw> (raw)
Some touchpads might get error while triggerring the sleep_control
command in SMBus interface. Do no operation for elan_smbus_sleep_control
function.
Signed-off-by: Dave Wang <dave.wang@emc.com.tw>
---
drivers/input/mouse/elan_i2c_smbus.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/input/mouse/elan_i2c_smbus.c b/drivers/input/mouse/elan_i2c_smbus.c
index bcb9ec4a7a6b..9ffb1f834507 100644
--- a/drivers/input/mouse/elan_i2c_smbus.c
+++ b/drivers/input/mouse/elan_i2c_smbus.c
@@ -89,10 +89,7 @@ static int elan_smbus_set_mode(struct i2c_client *client, u8 mode)
static int elan_smbus_sleep_control(struct i2c_client *client, bool sleep)
{
- if (sleep)
- return i2c_smbus_write_byte(client, ETP_SMBUS_SLEEP_CMD);
- else
- return 0; /* XXX should we send ETP_SMBUS_ENABLE_TP here? */
+ return 0; /* A no-op */
}
static int elan_smbus_power_control(struct i2c_client *client, bool enable)
--
2.17.1
reply other threads:[~2019-12-09 11:14 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191209111429.32315-1-dave.wang@emc.com.tw \
--to=dave.wang@emc.com.tw \
--cc=Dmitry.torokhov@gmail.com \
--cc=Linux-input@vger.kernel.org \
--cc=Linux-kernel@vger.kernel.org \
--cc=jingle.wu@emc.com.tw \
--cc=josh.chen@emc.com.tw \
--cc=kai.heng.feng@canonical.com \
--cc=phoenix@emc.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®