Re: [PATCH] regulator: max77650: add of_match table

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 963 bytes --]

On Tue, Dec 10, 2019 at 01:51:38PM +0100, Bartosz Golaszewski wrote:
> wt., 10 gru 2019 o 13:12 Mark Brown <broonie@kernel.org> napisał(a):

> > Why would we need to use a compatible string in a child node to load the
> > regulator driver, surely we can just register a platform device in the
> > MFD?

> The device is registered all right from MFD code, but the module won't
> be loaded automatically from user-space even with the right
> MODULE_ALIAS() for sub-nodes unless we define the
> MODULE_DEVICE_TABLE().

This seems to work fine for other drivers and the platform bus has to be
usable on systems that don't use DT so that doesn't sound right.  Which
MODULE_ALIAS() are you using exactly?

> Besides: the DT bindings define the compatible for sub-nodes already.
> We should probably conform to that.

I would say that's a mistake and should be fixed, this particular way of
loading the regulators is a Linux implementation detail.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]