From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92519C43603 for ; Tue, 10 Dec 2019 13:21:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5930A2073B for ; Tue, 10 Dec 2019 13:21:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575984100; bh=8P87T1yHgfauLuw8yUb0MnPXfIUFnN3hoj5S+HXjXIc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=wVz+CpbSYfIu69zl/m3/vcmno75JTfBh49Iik3wb/p4UrW+G05IUEzDnD9L0ZjaC4 UbgoFBMArWOQ0pleeKKsXUXaujPI7ZtfUL2gQ2mxDsqn8NDL5DD7yzh9SETJXEzDfp +U03aCC1/EbmGgm/WUnNcz9DbDgwIweM69Q3LOVU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727385AbfLJNVj (ORCPT ); Tue, 10 Dec 2019 08:21:39 -0500 Received: from foss.arm.com ([217.140.110.172]:43912 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727211AbfLJNVj (ORCPT ); Tue, 10 Dec 2019 08:21:39 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 378ED328; Tue, 10 Dec 2019 05:21:38 -0800 (PST) Received: from localhost (unknown [10.37.6.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AB59F3F52E; Tue, 10 Dec 2019 05:21:37 -0800 (PST) Date: Tue, 10 Dec 2019 13:21:36 +0000 From: Mark Brown To: Bartosz Golaszewski Cc: Liam Girdwood , Linux Kernel Mailing List , Bartosz Golaszewski Subject: Re: [PATCH] regulator: max77650: add of_match table Message-ID: <20191210132136.GG6110@sirena.org.uk> References: <20191210100725.11005-1-brgl@bgdev.pl> <20191210121227.GB6110@sirena.org.uk> <20191210130244.GE6110@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="QWpDgw58+k1mSFBj" Content-Disposition: inline In-Reply-To: X-Cookie: We have ears, earther...FOUR OF THEM! User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --QWpDgw58+k1mSFBj Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Dec 10, 2019 at 02:10:15PM +0100, Bartosz Golaszewski wrote: > wt., 10 gru 2019 o 14:02 Mark Brown napisa=C5=82(a): > > This seems to work fine for other drivers and the platform bus has to be > > usable on systems that don't use DT so that doesn't sound right. Which > > MODULE_ALIAS() are you using exactly? > MODULE_ALIAS("platform:max77650-regulator"); Huh, that should work... I wonder if adding a compatible to the DT has messed it up, does it work without the compatible in the .dts (and with the of_compatible removed from the MFD driver I guess)? > > > Besides: the DT bindings define the compatible for sub-nodes already. > > > We should probably conform to that. > > I would say that's a mistake and should be fixed, this particular way of > > loading the regulators is a Linux implementation detail. > Fixed by removing this from the bindings? Yeah. Though it may be too late, shame I didn't catch this when it was merged :( --QWpDgw58+k1mSFBj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl3vm98ACgkQJNaLcl1U h9Cafwf/a3oxPbhu5Pta4vakVb1PxMAJdTKejo/JdqsYMWi/ZQTBNNH/FfInbp7T D2zcDVZP/TNsmiEfpU2jPdKWjViPodD7lMFRqt+poeHmGDIqKBfO+MfQY8nZI5MH N5WA+PCYhePQeF0imK/9MnPfFigZwIPNWmyrY+S4hzqdmO4sMl0aSJ2YrR/o64sa Nu1qE8ALJ6S8anzLHm4X1iO3HGbpNHfEceZ4Ddr3UwWra4YpLNWLwoPGKX8XwN+V QqU6wPmbBsXhtlVSWBzoNhy0m6/1ZXswhnTE36MGLER5OtZg4/XTngVn3CrAZyDi MLjacZOLe5NREbuFhWuB0cgRlbFI+g== =nIJk -----END PGP SIGNATURE----- --QWpDgw58+k1mSFBj--