mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: info@metux.net
Cc: linux-kernel@vger.kernel.org, jchapman@katalix.com,
	netdev@vger.kernel.org
Subject: Re: [PATCH] net: l2tp: remove unneeded MODULE_VERSION() usage
Date: Thu, 12 Dec 2019 11:03:54 -0800 (PST)	[thread overview]
Message-ID: <20191212.110354.354662228217900367.davem@davemloft.net> (raw)
In-Reply-To: <20191212133613.25376-1-info@metux.net>

From: "Enrico Weigelt, metux IT consult" <info@metux.net>
Date: Thu, 12 Dec 2019 14:36:13 +0100

> Remove MODULE_VERSION(), as it isn't needed at all: the only version
> making sense is the kernel version.
> 
> Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>

Is there a plan to remove MODULE_VERSION across the entire kernel tree?

Where is that documented?

Otherwise what gave you the reason to make this change in the first place?

No context, no high level explanation of what's going on, so it's hard
to review and decide whether to accept your change sorry.

At the least, you will have to write a more complete commit log message.

  reply	other threads:[~2019-12-12 19:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-12 13:36 Enrico Weigelt, metux IT consult
2019-12-12 19:03 ` David Miller [this message]
2019-12-16  8:38   ` Enrico Weigelt, metux IT consult
2019-12-16  9:04   ` Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191212.110354.354662228217900367.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=info@metux.net \
    --cc=jchapman@katalix.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®