From: Dominik Brodowski <linux@dominikbrodowski.net>
To: Alexander Viro <viro@zeniv.linux.org.uk>,
Linus Torvalds <torvalds@linux-foundation.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@kernel.org>,
linux-kernel@vger.kernel.org
Subject: [GIT PULL] remove ksys_mount() and ksys_dup()
Date: Thu, 12 Dec 2019 19:14:17 +0100 [thread overview]
Message-ID: <20191212181422.31033-1-linux@dominikbrodowski.net> (raw)
The following changes since commit ae4b064e2a616b545acf02b8f50cc513b32c7522:
Merge tag 'afs-fixes-20191211' of git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs (2019-12-11 18:10:40 -0800)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/brodo/linux.git remove-ksys-mount-dup
for you to fetch changes up to 8243186f0cc7c57cf9d6a110cd7315c44e3e0be8:
fs: remove ksys_dup() (2019-12-12 19:00:36 +0100)
This small series replaces all in-kernel calls to the
userspace-focused ksys_mount() and ksys_dup() with calls
to kernel-centric functions:
For each replacement of ksys_mount() with do_mount(),
one needs to verify that the first and third parameter
(char *dev_name, char *type) are strings allocated in
kernelspace and that the fifth parameter (void *data)
is either NULL or refers to a full page (only occurence
in init/do_mounts.c::do_mount_root()). The second and
fourth parameters (char *dir_name, unsigned long flags)
are passed by ksys_mount() to do_mount() unchanged, and
therefore do not require particular care.
Moreover, instead of pretending to be userspace, the opening
of /dev/console as stdin/stdout/stderr can be implemented
using in-kernel functions as well. Thereby, ksys_dup() can
be removed for good.
---
Changes since the split-series patches[1,2]:
- merge both series (on suggestion by Linus)
- remove pointless cast (on suggestion by Linus)
[1] https://lore.kernel.org/lkml/20191212135724.331342-1-linux@dominikbrodowski.net/
[2] https://lore.kernel.org/lkml/20191212140752.347520-1-linux@dominikbrodowski.net/
Thanks,
Dominik
----------------------------------------------------------------
Dominik Brodowski (5):
devtmpfs: use do_mount() instead of ksys_mount()
initrd: use do_mount() instead of ksys_mount()
init: use do_mount() instead of ksys_mount()
init: unify opening /dev/console as stdin/stdout/stderr
fs: remove ksys_dup()
drivers/base/devtmpfs.c | 6 +++---
fs/file.c | 7 +------
fs/namespace.c | 10 ++--------
include/linux/device.h | 4 ++--
include/linux/initrd.h | 2 ++
include/linux/syscalls.h | 3 ---
init/do_mounts.c | 30 +++++++++++++++++++++++-------
init/do_mounts_initrd.c | 11 ++++-------
init/main.c | 31 ++++++++++++++++++++++++++-----
9 files changed, 63 insertions(+), 41 deletions(-)
--
2.24.1
next reply other threads:[~2019-12-12 18:14 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-12 18:14 Dominik Brodowski [this message]
2019-12-12 18:14 ` [PATCH 1/5] devtmpfs: use do_mount() instead of ksys_mount() Dominik Brodowski
2019-12-12 18:14 ` [PATCH 2/5] initrd: " Dominik Brodowski
2019-12-12 18:14 ` [PATCH 3/5] init: " Dominik Brodowski
2019-12-16 9:45 ` Borislav Petkov
2019-12-16 9:51 ` Dominik Brodowski
2019-12-16 10:19 ` Borislav Petkov
2019-12-12 18:14 ` [PATCH 4/5] init: unify opening /dev/console as stdin/stdout/stderr Dominik Brodowski
2019-12-12 18:14 ` [PATCH 5/5] fs: remove ksys_dup() Dominik Brodowski
2019-12-15 19:50 ` [GIT PULL] remove ksys_mount() and ksys_dup() Linus Torvalds
2019-12-15 20:50 ` pr-tracker-bot
[not found] ` <CAJmaN=ksaH5AgRUdVPGWKZzjEinU+goaCqedH1PW6OmKYc_TuA@mail.gmail.com>
2019-12-17 19:37 ` Greg Kroah-Hartman
2019-12-17 20:05 ` Jesse Barnes
2019-12-17 20:40 ` Linus Torvalds
2019-12-17 22:21 ` Jesse Barnes
2019-12-17 22:57 ` Al Viro
2019-12-17 23:23 ` Al Viro
2019-12-18 7:51 ` Dominik Brodowski
2019-12-18 13:37 ` Al Viro
2019-12-17 5:17 ` [PATCH 4/5] init: unify opening /dev/console as stdin/stdout/stderr youling257
2019-12-17 6:42 ` Dominik Brodowski
2019-12-17 9:33 ` youling 257
2019-12-17 21:14 ` Linus Torvalds
2019-12-18 4:10 ` youling 257
2019-12-18 8:03 ` Dominik Brodowski
2019-12-18 21:50 ` youling 257
2019-12-19 7:08 ` Dominik Brodowski
2019-12-19 9:34 ` youling 257
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191212181422.31033-1-linux@dominikbrodowski.net \
--to=linux@dominikbrodowski.net \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=rafael@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®