From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FB7FC43603 for ; Thu, 12 Dec 2019 23:42:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6A10721655 for ; Thu, 12 Dec 2019 23:42:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="RndbV6MA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731311AbfLLXm3 (ORCPT ); Thu, 12 Dec 2019 18:42:29 -0500 Received: from perceval.ideasonboard.com ([213.167.242.64]:56574 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726427AbfLLXm2 (ORCPT ); Thu, 12 Dec 2019 18:42:28 -0500 Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 2E677A2B; Fri, 13 Dec 2019 00:42:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1576194146; bh=Zigp7SWN2m4H6YUkBIdGVKmC/isQiYmdYdZtzt8Jztk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RndbV6MA+dGWmvZ8wzqXHSiv1XkHg7/dIXqIHfZSjpsohZe7cAXRD4W7DRtNJD5gq TAoQleBsM/vUVrxVAWvJ4bd1I49mwSPfuqw8FZRBq3naYfcCwFG5mnizDN/yy62WUT icU0UJEstnAAbSa74Yss0oOgUmaBCzv4t9St5zs8= Date: Fri, 13 Dec 2019 01:42:16 +0200 From: Laurent Pinchart To: Chuhong Yuan Cc: Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] media: omap3isp: add checks for devm_regulator_get Message-ID: <20191212234216.GE4892@pendragon.ideasonboard.com> References: <20191210091428.23448-1-hslester96@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20191210091428.23448-1-hslester96@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Chuhong, (CC'ing Sakari Ailus) Thank you for the patch. On Tue, Dec 10, 2019 at 05:14:28PM +0800, Chuhong Yuan wrote: > The driver misses checks for devm_regulator_get(). > Add checks to fix it. > > Signed-off-by: Chuhong Yuan > --- > drivers/media/platform/omap3isp/isp.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/drivers/media/platform/omap3isp/isp.c b/drivers/media/platform/omap3isp/isp.c > index 327c5716922a..ef3502182c3a 100644 > --- a/drivers/media/platform/omap3isp/isp.c > +++ b/drivers/media/platform/omap3isp/isp.c > @@ -2312,7 +2312,16 @@ static int isp_probe(struct platform_device *pdev) > > /* Regulators */ > isp->isp_csiphy1.vdd = devm_regulator_get(&pdev->dev, "vdd-csiphy1"); > + if (IS_ERR(isp->isp_csiphy1.vdd)) { > + ret = PTR_ERR(isp->isp_csiphy1.vdd); > + goto error; > + } > + > isp->isp_csiphy2.vdd = devm_regulator_get(&pdev->dev, "vdd-csiphy2"); > + if (IS_ERR(isp->isp_csiphy2.vdd)) { > + ret = PTR_ERR(isp->isp_csiphy2.vdd); > + goto error; > + } Those regulators are currently checked at runtime in omap3isp_csiphy_acquire(). The check is incorrect as it checks for NULL while vdd would contain an ERR_PTR, so there's a real issue. However, not all platforms support the CSI-2 receivers, and only omap3-n950.dts and omap3-n9.dts provide the regulators. They thus need to be kept optional. Would you like to provide another patch that fixes the checks in omap3isp_csiphy_acquire() ? > > /* Clocks > * -- Regards, Laurent Pinchart