From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE6DFC43603 for ; Tue, 17 Dec 2019 00:28:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A74CD206B7 for ; Tue, 17 Dec 2019 00:28:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727806AbfLQA2a (ORCPT ); Mon, 16 Dec 2019 19:28:30 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:57766 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726556AbfLQA2a (ORCPT ); Mon, 16 Dec 2019 19:28:30 -0500 Received: from localhost (unknown [IPv6:2601:601:9f00:1c3::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id C7A811557484D; Mon, 16 Dec 2019 16:28:29 -0800 (PST) Date: Mon, 16 Dec 2019 16:28:29 -0800 (PST) Message-Id: <20191216.162829.138398136452355108.davem@davemloft.net> To: pakki001@umn.edu Cc: kjlu@umn.edu, 3chas3@gmail.com, linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] fore200e: Fix incorrect checks of NULL pointer dereference From: David Miller In-Reply-To: <20191215161451.24221-1-pakki001@umn.edu> References: <20191215161451.24221-1-pakki001@umn.edu> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 16 Dec 2019 16:28:30 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Aditya Pakki Date: Sun, 15 Dec 2019 10:14:51 -0600 > In fore200e_send and fore200e_close, the pointers from the arguments > are dereferenced in the variable declaration block and then checked > for NULL. The patch fixes these issues by avoiding NULL pointer > dereferences. > > Signed-off-by: Aditya Pakki Applied to net-next.