From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63DE6C43603 for ; Mon, 16 Dec 2019 08:21:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 36DD920725 for ; Mon, 16 Dec 2019 08:21:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726890AbfLPIVD (ORCPT ); Mon, 16 Dec 2019 03:21:03 -0500 Received: from metis.ext.pengutronix.de ([85.220.165.71]:37309 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726758AbfLPIVC (ORCPT ); Mon, 16 Dec 2019 03:21:02 -0500 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iglcg-0007wx-JI; Mon, 16 Dec 2019 09:20:58 +0100 Received: from ukl by ptx.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1iglcg-0003qd-8E; Mon, 16 Dec 2019 09:20:58 +0100 Date: Mon, 16 Dec 2019 09:20:58 +0100 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Jitao Shi Cc: Thierry Reding , Matthias Brugger , linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, CK Hu , linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, sj.huang@mediatek.com Subject: Re: [PATCH v2 2/2] pwm/mtk_disp: move the reg enable trigger in config Message-ID: <20191216082058.xisbafewfttpkij6@pengutronix.de> References: <20191216070123.114719-1-jitao.shi@mediatek.com> <20191216070123.114719-3-jitao.shi@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20191216070123.114719-3-jitao.shi@mediatek.com> User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 16, 2019 at 03:01:23PM +0800, Jitao Shi wrote: > Remove the regist enable trigger setting in probe. > Move the trigger to mtk_disp_pwm_config(). Same as in patch 1: You describe what is (somewhat) obvious when reading the patch. But the motivation isn't clear. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |