From: Peter Zijlstra <peterz@infradead.org>
To: Thara Gopinath <thara.gopinath@linaro.org>
Cc: mingo@redhat.com, ionela.voinescu@arm.com,
vincent.guittot@linaro.org, rui.zhang@intel.com,
qperret@google.com, daniel.lezcano@linaro.org,
viresh.kumar@linaro.org, linux-kernel@vger.kernel.org,
amit.kachhap@gmail.com, javi.merino@kernel.org,
amit.kucheria@verdurent.com
Subject: Re: [Patch v6 1/7] sched/pelt.c: Add support to track thermal pressure
Date: Mon, 16 Dec 2019 14:43:24 +0100 [thread overview]
Message-ID: <20191216134324.GQ2844@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <1576123908-12105-2-git-send-email-thara.gopinath@linaro.org>
On Wed, Dec 11, 2019 at 11:11:42PM -0500, Thara Gopinath wrote:
> The
> difference here from rt/dl utilization tracking is that, instead of
> tracking time spent by a cpu running a rt/dl task through util_avg, the
> average thermal pressure is tracked through load_avg. This is because
> thermal pressure signal is weighted "delta" capacity and is not
> binary(util_avg is binary). "delta capacity" here means delta between the
> actual capacity of a cpu and the decreased capacity a cpu due to a thermal
> event.
I'm thinking that ^, would make a nice adding to that v.
> +/*
> + * thermal:
> + *
> + * load_sum = \Sum se->avg.load_sum
> + *
> + * util_avg and runnable_load_avg are not supported and meaningless.
> + *
> + */
> +int update_thermal_load_avg(u64 now, struct rq *rq, u64 capacity)
> +{
> + if (___update_load_sum(now, &rq->avg_thermal,
> + capacity,
> + capacity,
> + capacity)) {
> + ___update_load_avg(&rq->avg_thermal, 1, 1);
> + trace_pelt_thermal_tp(rq);
> + return 1;
> + }
> +
> + return 0;
> +}
next prev parent reply other threads:[~2019-12-16 13:43 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-12 4:11 [Patch v6 0/7] Introduce Thermal Pressure Thara Gopinath
2019-12-12 4:11 ` [Patch v6 1/7] sched/pelt.c: Add support to track thermal pressure Thara Gopinath
2019-12-16 13:43 ` Peter Zijlstra [this message]
2019-12-17 12:54 ` Dietmar Eggemann
[not found] ` <CALD-y_xHS7CaZ8SU--VP5+2F5Y8cVb4sw0XuG+JUpP_jxE7yuQ@mail.gmail.com>
2020-01-09 12:24 ` Dietmar Eggemann
2019-12-23 17:56 ` Ionela Voinescu
2020-01-02 14:40 ` Thara Gopinath
2019-12-12 4:11 ` [Patch v6 2/7] sched: Add hook to read per cpu " Thara Gopinath
2019-12-16 14:35 ` Peter Zijlstra
2019-12-17 12:54 ` Dietmar Eggemann
2019-12-12 4:11 ` [Patch v6 3/7] Add infrastructure to store and update instantaneous " Thara Gopinath
2019-12-16 14:37 ` Peter Zijlstra
2019-12-17 12:54 ` Dietmar Eggemann
2019-12-23 17:50 ` Ionela Voinescu
2019-12-12 4:11 ` [Patch v6 4/7] sched/fair: Enable periodic update of average " Thara Gopinath
2019-12-16 14:39 ` Peter Zijlstra
2019-12-16 17:59 ` Quentin Perret
2019-12-17 12:57 ` Dietmar Eggemann
2019-12-27 15:22 ` Thara Gopinath
2019-12-12 4:11 ` [Patch v6 5/7] sched/fair: update cpu_capacity to reflect " Thara Gopinath
2019-12-17 12:54 ` Dietmar Eggemann
2019-12-23 17:52 ` Ionela Voinescu
2019-12-12 4:11 ` [Patch v6 6/7] thermal/cpu-cooling: Update thermal pressure in case of a maximum frequency capping Thara Gopinath
2019-12-23 17:54 ` Ionela Voinescu
2019-12-12 4:11 ` [Patch v6 7/7] sched/fair: Enable tuning of decay period Thara Gopinath
2019-12-23 17:55 ` Ionela Voinescu
2019-12-16 14:56 ` [Patch v6 0/7] Introduce Thermal Pressure Peter Zijlstra
2020-01-11 15:04 ` Thara Gopinath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191216134324.GQ2844@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=amit.kachhap@gmail.com \
--cc=amit.kucheria@verdurent.com \
--cc=daniel.lezcano@linaro.org \
--cc=ionela.voinescu@arm.com \
--cc=javi.merino@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=qperret@google.com \
--cc=rui.zhang@intel.com \
--cc=thara.gopinath@linaro.org \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome