From: Mark Brown <broonie@kernel.org>
To: Robert Karszniewicz <r.karszniewicz@phytec.de>
Cc: linux-kernel@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH 1/1] regulator: of: Hide wrong warning regarding suspend state configuration
Date: Mon, 16 Dec 2019 17:35:47 +0000 [thread overview]
Message-ID: <20191216173547.GI4161@sirena.org.uk> (raw)
In-Reply-To: <1576515981-77867-2-git-send-email-r.karszniewicz@phytec.de>
[-- Attachment #1: Type: text/plain, Size: 633 bytes --]
On Mon, Dec 16, 2019 at 06:06:21PM +0100, Robert Karszniewicz wrote:
> A "No configuration" warning is falsely emitted in the case when the
> of-property regulator-always-on is set but regulator-(on|off)-in-suspend
> isn't set.
> This patch fixes the warning by explicitly setting always-on regulator's
> states to ENABLE_IN_SUSPEND.
Suspend states are basically completely separate to runtime states (and
we quite often have no software control over them) so it's not expected
that always-on will have an effect on suspend mode; the documentation
could use some cleanup here as it's mostly written from a runtime only
perspective.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-12-16 17:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-16 17:06 [PATCH 0/1] regulator: of: Does always-on imply on-in-suspend? Robert Karszniewicz
2019-12-16 17:06 ` [PATCH 1/1] regulator: of: Hide wrong warning regarding suspend state configuration Robert Karszniewicz
2019-12-16 17:35 ` Mark Brown [this message]
2019-12-16 17:25 ` [PATCH 0/1] regulator: of: Does always-on imply on-in-suspend? Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191216173547.GI4161@sirena.org.uk \
--to=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=r.karszniewicz@phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®