From: David Miller <davem@davemloft.net>
To: Jose.Abreu@synopsys.com
Cc: netdev@vger.kernel.org, Joao.Pinto@synopsys.com,
jakub.kicinski@netronome.com, peppe.cavallaro@st.com,
alexandre.torgue@st.com, mcoquelin.stm32@gmail.com,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 2/7] net: stmmac: Always arm TX Timer at end of transmission start
Date: Tue, 17 Dec 2019 23:01:11 -0800 (PST) [thread overview]
Message-ID: <20191217.230111.26076810894427486.davem@davemloft.net> (raw)
In-Reply-To: <c76b0d51238192f81a52231b214f252b20be55c6.1576586602.git.Jose.Abreu@synopsys.com>
From: Jose Abreu <Jose.Abreu@synopsys.com>
Date: Tue, 17 Dec 2019 13:46:06 +0100
> If TX Coalesce timer is enabled we should always arm it, otherwise we
> may hit the case where an interrupt is missed and the TX Queue will
> timeout.
>
> Arming the timer does not necessarly mean it will run the tx_clean()
> because this function is wrapped around NAPI launcher.
>
> Signed-off-by: Jose Abreu <Jose.Abreu@synopsys.com>
This is a bug fix and thus appropriate for net not net-next.
next prev parent reply other threads:[~2019-12-18 7:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 12:46 [PATCH net-next v2 0/7] net: stmmac: Improvements for -next Jose Abreu
2019-12-17 12:46 ` [PATCH net-next v2 1/7] net: stmmac: Print more information in DebugFS DMA Capabilities file Jose Abreu
2019-12-17 12:46 ` [PATCH net-next v2 2/7] net: stmmac: Always arm TX Timer at end of transmission start Jose Abreu
2019-12-18 7:01 ` David Miller [this message]
2019-12-17 12:46 ` [PATCH net-next v2 3/7] net: stmmac: Let TX and RX interrupts be independently enabled/disabled Jose Abreu
2019-12-17 12:46 ` [PATCH net-next v2 4/7] net: stmmac: Always use TX coalesce timer value when rescheduling Jose Abreu
2019-12-17 12:46 ` [PATCH net-next v2 5/7] net: stmmac: Add basic EST support for GMAC5+ Jose Abreu
2019-12-17 12:46 ` [PATCH net-next v2 6/7] net: stmmac: Add basic EST support for XGMAC Jose Abreu
2019-12-17 12:46 ` [PATCH net-next v2 7/7] net: stmmac: Integrate EST with TAPRIO scheduler API Jose Abreu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191217.230111.26076810894427486.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Joao.Pinto@synopsys.com \
--cc=Jose.Abreu@synopsys.com \
--cc=alexandre.torgue@st.com \
--cc=jakub.kicinski@netronome.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®