From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9ECEEC2D0BF for ; Tue, 17 Dec 2019 02:00:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 754DD2082E for ; Tue, 17 Dec 2019 02:00:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Tm1I36Oi" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726558AbfLQCAa (ORCPT ); Mon, 16 Dec 2019 21:00:30 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:47312 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726180AbfLQCAa (ORCPT ); Mon, 16 Dec 2019 21:00:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576548029; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=rPjKUP3c5OBgFxjGzOJRPYxmS5qHOOKhkgjmkw+YN2I=; b=Tm1I36OiIFq/QZzccKweDyHULLc1YkRbaknYVBgtMkYQApd5VUVWV0WIzC3o4o1oQnDvi/ GqEFE5k1WTjj7z0bd/Xb4MR+UPN3dLGCfLjfi2a3P9fD2aa4k/JqVueKvYFikFvIjAsAQr cibYedeZEGGqEpCH2L5EFg3FLLHUjIE= Received: from mail-yw1-f70.google.com (mail-yw1-f70.google.com [209.85.161.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-363-0F2LHWcmNpa0xjdqwvduhw-1; Mon, 16 Dec 2019 21:00:26 -0500 X-MC-Unique: 0F2LHWcmNpa0xjdqwvduhw-1 Received: by mail-yw1-f70.google.com with SMTP id 16so6992485ywz.5 for ; Mon, 16 Dec 2019 18:00:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:reply-to :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=rPjKUP3c5OBgFxjGzOJRPYxmS5qHOOKhkgjmkw+YN2I=; b=DjjxEcJnQ888D/IVoC4LJngedSINLBNO2ZhQ4IEBwghtKHViVGAeozV05AeEgGWavE uxDDCpwlGn0UVcwjxMR0iO8IfJnroKW0yektjhGdps8NoKaugTZxDTg3NiS0v6RY5D2b K6LVcarstJPh4eULOxFPvShqKxCBZsGSSAQO4K4UkhWba/C50pP/1ZFRO9Fq1UyGI1Co VoOLy6eg1mY0/UB9qEXAK4wTIO6lki4sKEtvUR4EOQ817Wz3EvkbXTK4qUvA4NKtMYfI o8CBnNOcgLnhG1e22myXDdU0TROAN+zaesHYNzLyDpRSbN4xexzc4NPSnIpdITSmZons ATew== X-Gm-Message-State: APjAAAUhtud0JSeSFO8DdFAKWQApJf3+QXbYqA3QN9TgzTwYFFkaDqDI lmPvdFcr5rRSxc3alF6ua9+29dAGqddMXYQKBTObWkJ2v/+Hqg4rDqncldGRkEYHGjh4OckuAKr Ttjw5kRSIe3SI7LsMbhx9ZsJN X-Received: by 2002:a25:8c9:: with SMTP id 192mr4617222ybi.328.1576548025512; Mon, 16 Dec 2019 18:00:25 -0800 (PST) X-Google-Smtp-Source: APXvYqzSHXlqGOcOwe8mrQawvzd98LxvqAZaVnHrkCZ/xB8ek5ZKZOwysxZHuTASPJ2GCZv3Avp1zw== X-Received: by 2002:a25:8c9:: with SMTP id 192mr4617202ybi.328.1576548025222; Mon, 16 Dec 2019 18:00:25 -0800 (PST) Received: from localhost (ip70-163-223-149.ph.ph.cox.net. [70.163.223.149]) by smtp.gmail.com with ESMTPSA id n1sm2256975ywe.78.2019.12.16.18.00.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Dec 2019 18:00:24 -0800 (PST) Date: Mon, 16 Dec 2019 19:00:22 -0700 From: Jerry Snitselaar To: Dan Williams Cc: Jarkko Sakkinen , Linux Kernel Mailing List , Christian Bundy , Peter Huewe , Jason Gunthorpe , Stefan Berger , stable , linux-integrity@vger.kernel.org Subject: Re: [PATCH v2] tpm_tis: reserve chip for duration of tpm_tis_core_init Message-ID: <20191217020022.knh7uxt4pn77wk5m@cantor> Reply-To: Jerry Snitselaar Mail-Followup-To: Dan Williams , Jarkko Sakkinen , Linux Kernel Mailing List , Christian Bundy , Peter Huewe , Jason Gunthorpe , Stefan Berger , stable , linux-integrity@vger.kernel.org References: <20191211231758.22263-1-jsnitsel@redhat.com> <20191211235455.24424-1-jsnitsel@redhat.com> <5aef0fbe28ed23b963c53d61445b0bac6f108642.camel@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon Dec 16 19, Dan Williams wrote: >On Mon, Dec 16, 2019 at 4:59 PM Jarkko Sakkinen > wrote: >> >> On Wed, 2019-12-11 at 16:54 -0700, Jerry Snitselaar wrote: >> > Instead of repeatedly calling tpm_chip_start/tpm_chip_stop when >> > issuing commands to the tpm during initialization, just reserve the >> > chip after wait_startup, and release it when we are ready to call >> > tpm_chip_register. >> > >> > Cc: Christian Bundy >> > Cc: Dan Williams >> > Cc: Peter Huewe >> > Cc: Jarkko Sakkinen >> > Cc: Jason Gunthorpe >> > Cc: Stefan Berger >> > Cc: stable@vger.kernel.org >> > Cc: linux-integrity@vger.kernel.org >> > Fixes: a3fbfae82b4c ("tpm: take TPM chip power gating out of tpm_transmit()") >> > Fixes: 5b359c7c4372 ("tpm_tis_core: Turn on the TPM before probing IRQ's") >> > Signed-off-by: Jerry Snitselaar >> >> I pushed to my master with minor tweaks and added my tags. >> >> Please check before I put it to linux-next. > >I don't see it yet here: > >http://git.infradead.org/users/jjs/linux-tpmdd.git/shortlog/refs/heads/master > >However, I wanted to make sure you captured that this does *not* fix >the interrupt issue. I.e. make sure you remove the "Fixes: >5b359c7c4372 ("tpm_tis_core: Turn on the TPM before probing IRQ's")" >tag. > >With that said, are you going to include the revert of: > >1ea32c83c699 tpm_tis_core: Set TPM_CHIP_FLAG_IRQ before probing for interrupts Dan, with the above reverted do you still get the screaming interrupt? >5b359c7c4372 tpm_tis_core: Turn on the TPM before probing IRQ's > >...in your -rc3 pull? >