From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: kbuild test robot <lkp@intel.com>,
"kernelci . org bot" <bot@kernelci.org>,
Olof's autobuilder <build@lixom.net>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Karsten Keil <isdn@linux-pingi.de>,
David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [staging-next] isdn: don't mark kcapi_proc_exit as __exit
Date: Tue, 17 Dec 2019 09:00:54 +0100 [thread overview]
Message-ID: <20191217080054.GA2525210@kroah.com> (raw)
In-Reply-To: <20191216194909.1983639-1-arnd@arndb.de>
On Mon, Dec 16, 2019 at 08:48:56PM +0100, Arnd Bergmann wrote:
> As everybody pointed out by now, my patch to clean up CAPI introduced
> a link time warning, as the two parts of the capi driver are now in
> one module and the exit function may need to be called in the error
> path of the init function:
>
> >> WARNING: drivers/isdn/capi/kernelcapi.o(.text+0xea4): Section mismatch in reference from the function kcapi_exit() to the function .exit.text:kcapi_proc_exit()
> The function kcapi_exit() references a function in an exit section.
> Often the function kcapi_proc_exit() has valid usage outside the exit section
> and the fix is to remove the __exit annotation of kcapi_proc_exit.
>
> Remove the incorrect __exit annotation.
>
> Reported-by: kbuild test robot <lkp@intel.com>
> Reported-by: kernelci.org bot <bot@kernelci.org>
> Reported-by: Olof's autobuilder <build@lixom.net>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/isdn/capi/kcapi_proc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks for this, now applied.
greg k-h
prev parent reply other threads:[~2019-12-17 8:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-16 19:48 Arnd Bergmann
2019-12-17 8:00 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191217080054.GA2525210@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=bot@kernelci.org \
--cc=build@lixom.net \
--cc=davem@davemloft.net \
--cc=isdn@linux-pingi.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=netdev@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®