From: Petr Mladek <pmladek@suse.com>
To: Shuah Khan <skhan@linuxfoundation.org>
Cc: jpoimboe@redhat.com, jikos@kernel.org, mbenes@suse.cz,
joe.lawrence@redhat.com, shuah@kernel.org,
live-patching@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] selftests: livepatch: Fix it to do root uid check and skip
Date: Tue, 17 Dec 2019 10:02:10 +0100 [thread overview]
Message-ID: <20191217090210.ky3il3qu4jkr2vaa@pathway.suse.cz> (raw)
In-Reply-To: <20191216191840.15188-1-skhan@linuxfoundation.org>
On Mon 2019-12-16 12:18:40, Shuah Khan wrote:
> livepatch test configures the system and debug environment to run
> tests. Some of these actions fail without root access and test
> dumps several permission denied messages before it exits.
>
> Fix test-state.sh to call setup_config instead of set_dynamic_debug
> as suggested by Petr Mladek <pmladek@suse.com>
>
> Fix it to check root uid and exit with skip code instead.
>
> Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
Reviewed-by: Petr Mladek <pmladek@suse.com>
Shuah, I assume that you will push this fix via linux-kselftest tree.
Please, tell us if you have other preference.
Best Regards,
Petr
next prev parent reply other threads:[~2019-12-17 9:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-16 19:18 Shuah Khan
2019-12-16 21:01 ` Joe Lawrence
2019-12-17 9:02 ` Petr Mladek [this message]
2019-12-17 15:08 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191217090210.ky3il3qu4jkr2vaa@pathway.suse.cz \
--to=pmladek@suse.com \
--cc=jikos@kernel.org \
--cc=joe.lawrence@redhat.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®