mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Dave Kim <david.kim@ncipher.com>
Cc: arnd@arndb.de, linux-kernel@vger.kernel.org,
	Tim Magee <tim.magee@ncipher.com>
Subject: Re: [PATCH 1/1] drivers: misc: Add support for nCipher HSM devices
Date: Tue, 17 Dec 2019 14:32:34 +0100	[thread overview]
Message-ID: <20191217133234.GB3362771@kroah.com> (raw)
In-Reply-To: <20191217132244.14768-2-david.kim@ncipher.com>

On Tue, Dec 17, 2019 at 01:22:44PM +0000, Dave Kim wrote:
> From: David Kim <david.kim@ncipher.com>
> 
> Introduce the driver for nCipher's Solo and Solo XC range of PCIe hardware
> security modules (HSM), which provide key creation/management and
> cryptography services.

A bit more description of exactly _what_ these devices do would be
helpful.

Also, how does userspace interact with the driver?  What api(s) are you
using/creating?  What userspace tools work with the device?

In short, we need more than just a one sentance description to be able
to properly review the code and provide text for a user to know what to
do with this driver.

Can you fix all that up and send a v2?

thanks,

greg k-h

  reply	other threads:[~2019-12-17 13:32 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-17 13:22 [PATCH 0/1] " Dave Kim
2019-12-17 13:22 ` [PATCH 1/1] " Dave Kim
2019-12-17 13:32   ` Greg KH [this message]
2019-12-17 13:53     ` Kim, David
2019-12-17 14:05       ` Greg KH
2019-12-20 15:50     ` Kim, David
2019-12-17 13:36   ` Greg KH
2019-12-20 15:27     ` Kim, David
2019-12-17 13:37   ` Greg KH
2019-12-17 13:38   ` Greg KH
2019-12-20 15:30     ` Kim, David

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191217133234.GB3362771@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=arnd@arndb.de \
    --cc=david.kim@ncipher.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tim.magee@ncipher.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®