From: Benoit Parrot <bparrot@ti.com>
To: Rob Herring <robh+dt@kernel.org>
Cc: Maxime Ripard <mripard@kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
Jyri Sarha <jsarha@ti.com>
Subject: Re: [PATCH] dtc: checks: check_graph_port: skip node name check in overlay case
Date: Tue, 17 Dec 2019 10:06:29 -0600 [thread overview]
Message-ID: <20191217160629.6iwpnd4p6glxbohg@ti.com> (raw)
In-Reply-To: <20191122191631.2382-1-bparrot@ti.com>
Ping!
Benoit Parrot <bparrot@ti.com> wrote on Fri [2019-Nov-22 13:16:31 -0600]:
> In check_graph_port() we need to skip the node name check in the overlay
> case as it causes a false positive warning.
>
> Signed-off-by: Benoit Parrot <bparrot@ti.com>
> ---
> checks.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/checks.c b/checks.c
> index 756f0fa9203f..6b6712da146a 100644
> --- a/checks.c
> +++ b/checks.c
> @@ -1707,7 +1707,8 @@ static void check_graph_port(struct check *c, struct dt_info *dti,
> if (node->bus != &graph_port_bus)
> return;
>
> - if (!strprefixeq(node->name, node->basenamelen, "port"))
> + if (!strprefixeq(node->name, node->basenamelen, "port") &&
> + !(dti->dtsflags & DTSF_PLUGIN))
> FAIL(c, dti, node, "graph port node name should be 'port'");
>
> check_graph_reg(c, dti, node);
prev parent reply other threads:[~2019-12-17 16:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-22 19:16 Benoit Parrot
2019-12-17 16:06 ` Benoit Parrot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191217160629.6iwpnd4p6glxbohg@ti.com \
--to=bparrot@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=jsarha@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mripard@kernel.org \
--cc=peter.ujfalusi@ti.com \
--cc=robh+dt@kernel.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®