From: Tan Xiaojun <tanxiaojun@huawei.com>
To: <peterz@infradead.org>, <mingo@redhat.com>, <acme@kernel.org>,
<alexander.shishkin@linux.intel.com>, <jolsa@redhat.com>,
<namhyung@kernel.org>, <ak@linux.intel.com>,
<adrian.hunter@intel.com>, <yao.jin@linux.intel.com>,
<tmricht@linux.ibm.com>, <brueckner@linux.ibm.com>,
<songliubraving@fb.com>, <gregkh@linuxfoundation.org>,
<kim.phillips@arm.com>, <James.Clark@arm.com>,
<jeremy.linton@arm.com>
Cc: <gengdongjiu@huawei.com>, <wxf.wang@hisilicon.com>,
<liwei391@huawei.com>, <tanxiaojun@huawei.com>,
<liuqi115@hisilicon.com>, <huawei.libin@huawei.com>,
<linux-kernel@vger.kernel.org>,
<linux-perf-users@vger.kernel.org>
Subject: [PATCH 5/6] perf tools: add perf_evlist__terminate() for terminate
Date: Wed, 18 Dec 2019 15:54:54 +0800 [thread overview]
Message-ID: <20191218075455.5106-6-tanxiaojun@huawei.com> (raw)
In-Reply-To: <20191218075455.5106-1-tanxiaojun@huawei.com>
From: Wei Li <liwei391@huawei.com>
In __cmd_record(), when receiving SIGINT(ctrl + c), a done flag will
be set and the event list will be disabled by perf_evlist__disable()
once.
While in auxtrace_record.read_finish(), the related events will be
enabled again, if they are continuous, the recording seems to be endless.
Mark the evlist's state as terminated, preparing for the following fix.
Signed-off-by: Wei Li <liwei391@huawei.com>
Tested-by: Qi Liu <liuqi115@hisilicon.com>
---
tools/perf/builtin-record.c | 1 +
tools/perf/util/evlist.c | 14 ++++++++++++++
tools/perf/util/evlist.h | 1 +
tools/perf/util/evsel.h | 1 +
4 files changed, 17 insertions(+)
diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
index fb19ef63cc35..5646949f8cc7 100644
--- a/tools/perf/builtin-record.c
+++ b/tools/perf/builtin-record.c
@@ -1716,6 +1716,7 @@ static int __cmd_record(struct record *rec, int argc, const char **argv)
if (done && !disabled && !target__none(&opts->target)) {
trigger_off(&auxtrace_snapshot_trigger);
evlist__disable(rec->evlist);
+ evlist__terminate(rec->evlist);
disabled = true;
}
}
diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c
index b9c7e5271611..b04794cd8586 100644
--- a/tools/perf/util/evlist.c
+++ b/tools/perf/util/evlist.c
@@ -377,6 +377,20 @@ bool evsel__cpu_iter_skip(struct evsel *ev, int cpu)
return true;
}
+void evlist__terminate(struct evlist *evlist)
+{
+ struct evsel *pos;
+
+ evlist__for_each_entry(evlist, pos) {
+ if (pos->disabled || !perf_evsel__is_group_leader(pos) || !pos->core.fd)
+ continue;
+ evsel__disable(pos);
+ pos->terminated = true;
+ }
+
+ evlist->enabled = false;
+}
+
void evlist__disable(struct evlist *evlist)
{
struct evsel *pos;
diff --git a/tools/perf/util/evlist.h b/tools/perf/util/evlist.h
index f5bd5c386df1..9fbd0ce2a1c4 100644
--- a/tools/perf/util/evlist.h
+++ b/tools/perf/util/evlist.h
@@ -206,6 +206,7 @@ void evlist__munmap(struct evlist *evlist);
size_t evlist__mmap_size(unsigned long pages);
+void evlist__terminate(struct evlist *evlist);
void evlist__disable(struct evlist *evlist);
void evlist__enable(struct evlist *evlist);
void perf_evlist__toggle_enable(struct evlist *evlist);
diff --git a/tools/perf/util/evsel.h b/tools/perf/util/evsel.h
index dc14f4a823cd..8e8a2cb41de8 100644
--- a/tools/perf/util/evsel.h
+++ b/tools/perf/util/evsel.h
@@ -104,6 +104,7 @@ struct evsel {
perf_evsel__sb_cb_t *cb;
void *data;
} side_band;
+ bool terminated;
};
struct perf_missing_features {
--
2.17.1
next prev parent reply other threads:[~2019-12-18 7:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-18 7:54 [PATCH 0/6] perf tools: Add support for some spe events and precise ip Tan Xiaojun
2019-12-18 7:54 ` [PATCH 1/6] perf tools: Move arm-spe-pkt-decoder.h/c to the new dir Tan Xiaojun
2019-12-18 7:54 ` [PATCH 2/6] perf tools: Add support for "report" for some spe events Tan Xiaojun
2019-12-18 7:54 ` [PATCH 3/6] perf report: Add --spe options for arm-spe Tan Xiaojun
2019-12-18 7:54 ` [PATCH 4/6] perf tools: Support "branch-misses:pp" on arm64 Tan Xiaojun
2019-12-18 7:54 ` Tan Xiaojun [this message]
2019-12-18 7:54 ` [PATCH 6/6] perf tools: arm-spe: fix record hang after being terminated Tan Xiaojun
2020-01-15 12:02 ` James Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191218075455.5106-6-tanxiaojun@huawei.com \
--to=tanxiaojun@huawei.com \
--cc=James.Clark@arm.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=brueckner@linux.ibm.com \
--cc=gengdongjiu@huawei.com \
--cc=gregkh@linuxfoundation.org \
--cc=huawei.libin@huawei.com \
--cc=jeremy.linton@arm.com \
--cc=jolsa@redhat.com \
--cc=kim.phillips@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=liuqi115@hisilicon.com \
--cc=liwei391@huawei.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=songliubraving@fb.com \
--cc=tmricht@linux.ibm.com \
--cc=wxf.wang@hisilicon.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®