From: Sudeep Holla <sudeep.holla@arm.com>
To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Cc: Sudeep Holla <sudeep.holla@arm.com>,
Cristian Marussi <cristian.marussi@arm.com>
Subject: [PATCH v2 03/11] firmware: arm_scmi: Add names to scmi devices created
Date: Wed, 18 Dec 2019 11:17:34 +0000 [thread overview]
Message-ID: <20191218111742.29731-4-sudeep.holla@arm.com> (raw)
In-Reply-To: <20191218111742.29731-1-sudeep.holla@arm.com>
Now that scmi bus provides option to create named scmi device, let us
create the default devices with names. This will help to add names for
matching to respective drivers and eventually to add multiple devices
and drivers per protocol.
Reviewed-by: Cristian Marussi <cristian.marussi@arm.com>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
---
drivers/firmware/arm_scmi/driver.c | 36 +++++++++++++++++++++++++++++-
1 file changed, 35 insertions(+), 1 deletion(-)
diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c
index 2952fcd8dd8a..0bbdc7c9eb0f 100644
--- a/drivers/firmware/arm_scmi/driver.c
+++ b/drivers/firmware/arm_scmi/driver.c
@@ -829,6 +829,40 @@ scmi_create_protocol_device(struct device_node *np, struct scmi_info *info,
scmi_set_handle(sdev);
}
+#define MAX_SCMI_DEV_PER_PROTOCOL 2
+struct scmi_prot_devnames {
+ int protocol_id;
+ char *names[MAX_SCMI_DEV_PER_PROTOCOL];
+};
+
+static struct scmi_prot_devnames devnames[] = {
+ { SCMI_PROTOCOL_POWER, { "genpd" },},
+ { SCMI_PROTOCOL_PERF, { "cpufreq" },},
+ { SCMI_PROTOCOL_CLOCK, { "clocks" },},
+ { SCMI_PROTOCOL_SENSOR, { "hwmon" },},
+ { SCMI_PROTOCOL_RESET, { "reset" },},
+};
+
+static inline void
+scmi_create_protocol_devices(struct device_node *np, struct scmi_info *info,
+ int prot_id)
+{
+ int loop, cnt;
+
+ for (loop = 0; loop < ARRAY_SIZE(devnames); loop++) {
+ if (devnames[loop].protocol_id != prot_id)
+ continue;
+
+ for (cnt = 0; cnt < ARRAY_SIZE(devnames[loop].names); cnt++) {
+ const char *name = devnames[loop].names[cnt];
+
+ if (name)
+ scmi_create_protocol_device(np, info, prot_id,
+ name);
+ }
+ }
+}
+
static int scmi_probe(struct platform_device *pdev)
{
int ret;
@@ -897,7 +931,7 @@ static int scmi_probe(struct platform_device *pdev)
continue;
}
- scmi_create_protocol_device(child, info, prot_id, NULL);
+ scmi_create_protocol_devices(child, info, prot_id);
}
return 0;
--
2.17.1
next prev parent reply other threads:[~2019-12-18 11:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-18 11:17 [PATCH v2 00/11] firmware: arm_scmi: Add support for multiple device per protocol Sudeep Holla
2019-12-18 11:17 ` [PATCH v2 01/11] " Sudeep Holla
2019-12-18 11:17 ` [PATCH v2 02/11] firmware: arm_scmi: Skip scmi mbox channel setup for addtional devices Sudeep Holla
2019-12-18 11:17 ` Sudeep Holla [this message]
2019-12-18 11:17 ` [PATCH v2 04/11] firmware: arm_scmi: Add versions and identifier attributes using dev_groups Sudeep Holla
2019-12-18 11:17 ` [PATCH v2 05/11] firmware: arm_scmi: Match scmi device by both name and protocol id Sudeep Holla
2019-12-18 11:17 ` [PATCH v2 06/11] firmware: arm_scmi: Stash version in protocol init functions Sudeep Holla
2019-12-18 11:17 ` [PATCH v2 07/11] firmware: arm_scmi: Skip protocol initialisation for additional devices Sudeep Holla
2019-12-24 14:33 ` Sudeep Holla
2019-12-24 14:35 ` Cristian Marussi
2019-12-18 11:17 ` [PATCH v2 08/11] clk: scmi: Match scmi device by both name and protocol id Sudeep Holla
2019-12-26 22:04 ` Stephen Boyd
2019-12-18 11:17 ` [PATCH v2 09/11] cpufreq: " Sudeep Holla
2019-12-18 11:17 ` [PATCH v2 10/11] hwmon: (scmi-hwmon) " Sudeep Holla
2020-01-04 16:19 ` Guenter Roeck
2020-01-06 10:39 ` Sudeep Holla
2019-12-18 11:17 ` [PATCH v2 11/11] reset: reset-scmi: " Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191218111742.29731-4-sudeep.holla@arm.com \
--to=sudeep.holla@arm.com \
--cc=cristian.marussi@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®