From: Greg KH <gregkh@linuxfoundation.org>
To: Simran Sandhu <f20171454@hyderabad.bits-pilani.ac.in>
Cc: sudipm.mukherjee@gmail.comm, teddy.wang@siliconmotion.com,
linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] Staging: sm750fb: sm750.h:Fixed Coding Style Issue
Date: Thu, 19 Dec 2019 10:35:04 +0100 [thread overview]
Message-ID: <20191219093504.GB1198515@kroah.com> (raw)
In-Reply-To: <20191219090553.13243-1-f20171454@hyderabad.bits-pilani.ac.in>
On Thu, Dec 19, 2019 at 02:35:53PM +0530, Simran Sandhu wrote:
> Fixed the checkpath error: function definition arguments
> should also have identifier names
>
> Signed-of-by: Simran Sandhu <f20171454@hyderabad.bits-pilani.ac.in>
> ---
> drivers/staging/sm750fb/sm750.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h
> index ce90adcb449d..cf986bad7210 100644
> --- a/drivers/staging/sm750fb/sm750.h
> +++ b/drivers/staging/sm750fb/sm750.h
> @@ -66,9 +66,9 @@ struct lynx_accel {
> u32, u32, u32, u32,
> u32, u32, u32, u32);
>
> - int (*de_imageblit)(struct lynx_accel *, const char *, u32, u32, u32, u32,
> - u32, u32, u32, u32,
> - u32, u32, u32, u32);
> + int (*de_imageblit)(struct lynx_accel *A, const char *B, u32 C, u32 D,
> + u32 E, u32 F, u32 G, u32 H, u32 I,
> + u32 J, u32 K, u32 L, u32 M, u32 N);
>
You just caused another coding style violation with this one :(
Always run your patches though checkpatch.pl to ensure you do not add
new problems when trying to fix up things.
greg k-h
prev parent reply other threads:[~2019-12-19 9:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-19 9:05 Simran Sandhu
2019-12-19 9:35 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191219093504.GB1198515@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=f20171454@hyderabad.bits-pilani.ac.in \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.comm \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®