From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65E1AC2D0C0 for ; Thu, 19 Dec 2019 15:40:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3C29A206EC for ; Thu, 19 Dec 2019 15:40:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576770017; bh=zjrNAQxSo9YIjVhVdnA6CeKJyfbiwv9WV9GOdbURvIU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=VTBMaQAfVB2BwBwZAIOCefT26ZqMxXOSHQOToQ8HUd8CENrDL1dI9fLfIZE5583ST Q/sWNL/drkBl9EwkYLzwt6WffcyLcdp9hlisAMBQrYYoceN9tzkIX8TWmtpYgsMAvv 4HJuGjzy2A4ZDsHckZd2WiL1t9M5UumSvPHGgCbQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726818AbfLSPkQ (ORCPT ); Thu, 19 Dec 2019 10:40:16 -0500 Received: from mail.kernel.org ([198.145.29.99]:41092 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726758AbfLSPkP (ORCPT ); Thu, 19 Dec 2019 10:40:15 -0500 Received: from localhost (unknown [122.178.234.230]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2F0BD206EC; Thu, 19 Dec 2019 15:40:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576770015; bh=zjrNAQxSo9YIjVhVdnA6CeKJyfbiwv9WV9GOdbURvIU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=O2pKAqW6CchuZ3q3t13kjD7vXWpT9Q6DWWEcJ3b2q6OcukXchJLA4qjr06s04Alqb ON8en1yzwROMzEYLJNLhf74MUqZdYay+NMrwsA+V2XV41AXRiEUwUdM5dpaneCJy0l W3JENpfEH82BvmCyxPXvk9LlYL+509+eUYOKR65k= Date: Thu, 19 Dec 2019 21:10:09 +0530 From: Vinod Koul To: Jeffrey Hugo Cc: Kishon Vijay Abraham I , MSM , Bjorn Andersson , Andy Gross , Can Guo , lkml Subject: Re: [PATCH 1/4] phy: qcom-qmp: Increase the phy init timeout Message-ID: <20191219154009.GX2536@vkoul-mobl> References: <20191219150433.2785427-1-vkoul@kernel.org> <20191219150433.2785427-2-vkoul@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19-12-19, 08:29, Jeffrey Hugo wrote: > On Thu, Dec 19, 2019 at 8:04 AM Vinod Koul wrote: > > > > If we do full reset of the phy, it seems to take a couple of ms to come > > up on my system so increase the timeout to 10ms. > > > > This was found by full reset addition by commit 870b1279c7a0 > > ("scsi: ufs-qcom: Add reset control support for host controller") and > > fixes the regression to platforms by this commit. > > > > Suggested-by: Can Guo > > Signed-off-by: Vinod Koul > > Reviewed-by: Jeffrey Hugo > Tested-by: Jeffrey Hugo > > Tested on the Lenovo Miix 630 laptop (a msm8998 based system). This > addresses the regression. Thanks Jeff for quick test and reviews! Appreciate it. > > --- > > drivers/phy/qualcomm/phy-qcom-qmp.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qualcomm/phy-qcom-qmp.c > > index 091e20303a14..c2e800a3825a 100644 > > --- a/drivers/phy/qualcomm/phy-qcom-qmp.c > > +++ b/drivers/phy/qualcomm/phy-qcom-qmp.c > > @@ -66,7 +66,7 @@ > > /* QPHY_V3_PCS_MISC_CLAMP_ENABLE register bits */ > > #define CLAMP_EN BIT(0) /* enables i/o clamp_n */ > > > > -#define PHY_INIT_COMPLETE_TIMEOUT 1000 > > +#define PHY_INIT_COMPLETE_TIMEOUT 100000 > > #define POWER_DOWN_DELAY_US_MIN 10 > > #define POWER_DOWN_DELAY_US_MAX 11 > > > > -- > > 2.23.0 > > -- ~Vinod