From: Peter Zijlstra <peterz@infradead.org>
To: ktkhai@virtuozzo.com
Cc: Steven Rostedt <rostedt@goodmis.org>,
"mingo@redhat.com" <mingo@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
"juri.lelli@redhat.com" <juri.lelli@redhat.com>,
"vincent.guittot@linaro.org" <vincent.guittot@linaro.org>,
"dietmar.eggemann@arm.com" <dietmar.eggemann@arm.com>,
"bsegall@google.com" <bsegall@google.com>,
Mel Gorman <mgorman@suse.de>
Subject: Re: [PATCH RESEND v3] sched: Micro optimization in pick_next_task() and in check_preempt_curr()
Date: Fri, 20 Dec 2019 10:26:31 +0100 [thread overview]
Message-ID: <20191220092631.GB2844@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <711a9c4b-ff32-1136-b848-17c622d548f3@yandex.ru>
On Fri, Dec 20, 2019 at 12:27:05AM +0300, Kirill Tkhai wrote:
> This introduces an optimization based on xxx_sched_class addresses
> in two hot scheduler functions: pick_next_task() and check_preempt_curr().
>
> It is possible to compare pointers to sched classes to check, which
> of them has a higher priority, instead of current iterations using
> for_each_class().
>
> One more result of the patch is that size of object file becomes a little
> less (excluding added BUG_ON(), which goes in __init section):
>
> $size kernel/sched/core.o
> text data bss dec hex filename
> before: 66446 18957 676 86079 1503f kernel/sched/core.o
> after: 66398 18957 676 86031 1500f kernel/sched/core.o
>
> Signed-off-by: Kirill Tkhai <ktkhai@virtuozzo.com>
Thanks guys!
next prev parent reply other threads:[~2019-12-20 9:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-19 16:35 [PATCH] sched: Force the address order of each sched class descriptor Steven Rostedt
2019-12-19 20:12 ` [PATCH v3] sched: Micro optimization in pick_next_task() and in check_preempt_curr() Kirill Tkhai
2019-12-19 21:04 ` Steven Rostedt
[not found] ` <711a9c4b-ff32-1136-b848-17c622d548f3@yandex.ru>
2019-12-20 9:26 ` Peter Zijlstra [this message]
2020-06-25 11:53 ` [tip: sched/core] " tip-bot2 for Kirill Tkhai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191220092631.GB2844@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=ktkhai@virtuozzo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®