From: "Michal Suchánek" <msuchanek@suse.de>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH] scsi: blacklist: add VMware ESXi cdrom - broken tray emulation
Date: Fri, 20 Dec 2019 15:39:22 +0100 [thread overview]
Message-ID: <20191220143922.GM4113@kitsune.suse.cz> (raw)
In-Reply-To: <yq1pngjc2pr.fsf@oracle.com>
On Thu, Dec 19, 2019 at 06:31:12PM -0500, Martin K. Petersen wrote:
>
> Michal,
>
> >> Please don't introduce a blist flag to work around deficiencies in the
> >> matching interface. I suggest you tweak the matching functions so they
> >> handle a NULL vendor string correctly.
> >
> > I don't think that will work with the interface for dynamically adding
> > entries through sysfs.
>
> Please make it work :)
>
> There's nothing conceptually wrong with being able to do:
>
> echo ":Model:Flags" > /proc/scsi/device_info
>
> We keep running into issues where the same device needs to be listed
> many times because it gets branded by different vendors.
>
Is there any description of what the format is supposed to be?
From the current code it looks like comma separated list of blacklist
entries that may be optionally quoted in some way.
The quoting is basically ignored but it is not clear if the inidividual
entries are supposed to be quoted or the whole thing.
Thanks
Michal
next prev parent reply other threads:[~2019-12-20 14:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 18:08 Michal Suchanek
2019-12-17 22:28 ` Martin K. Petersen
2019-12-19 14:34 ` Michal Suchánek
2019-12-19 23:31 ` Martin K. Petersen
2019-12-20 14:39 ` Michal Suchánek [this message]
2019-12-21 11:54 ` Michal Suchánek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191220143922.GM4113@kitsune.suse.cz \
--to=msuchanek@suse.de \
--cc=axboe@kernel.dk \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®