From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA445C43603 for ; Fri, 20 Dec 2019 14:47:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AD765218AC for ; Fri, 20 Dec 2019 14:47:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576853233; bh=vOWJl/FwdZ6SaPEm1U9jWsr8pbWL/1mh+kI9cCIMa5A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=dnGKbluK1Lr3T3bV0mc4L/yrhUNi8VzRYPL7ZC3YWW/qKY19+twmvHFY/EZ9XuaGR MaA0Ck4coNNWN+S39c6GoENgH4EMMecSAtj0fi8OYpv3RgnNp0kRnjFea2nGeIJ7KQ afKwAd9srQRjPD5ilL8wk9jAQxJzhS3m7wFg722o= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727706AbfLTOrN (ORCPT ); Fri, 20 Dec 2019 09:47:13 -0500 Received: from mail.kernel.org ([198.145.29.99]:45354 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727615AbfLTOrK (ORCPT ); Fri, 20 Dec 2019 09:47:10 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DD1BD24679; Fri, 20 Dec 2019 14:47:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576853229; bh=vOWJl/FwdZ6SaPEm1U9jWsr8pbWL/1mh+kI9cCIMa5A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TeR4HC9PE9IdUY6tsrMx1zfRGrVceRUbnwpD5uqmE0yPkMP8/j7FEOjnv1hKZZw/I +2HQgt4XzjvQ63UVNpBv2FilYxK3EWG3LrFsx7nAN0uGSuNvEEv0fi966zdHYvv0kz VweKQr8aYc7+6ub1mszCu6J9XSbGfGulF+q7ojk8= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Zhiqiang Liu , Song Liu , Sasha Levin , linux-raid@vger.kernel.org Subject: [PATCH AUTOSEL 4.9 08/14] md: raid1: check rdev before reference in raid1_sync_request func Date: Fri, 20 Dec 2019 09:46:52 -0500 Message-Id: <20191220144658.10414-8-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191220144658.10414-1-sashal@kernel.org> References: <20191220144658.10414-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Zhiqiang Liu [ Upstream commit 028288df635f5a9addd48ac4677b720192747944 ] In raid1_sync_request func, rdev should be checked before reference. Signed-off-by: Zhiqiang Liu Signed-off-by: Song Liu Signed-off-by: Sasha Levin --- drivers/md/raid1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c index 9892c41de4419..8a50da4f148f9 100644 --- a/drivers/md/raid1.c +++ b/drivers/md/raid1.c @@ -2633,7 +2633,7 @@ static sector_t raid1_sync_request(struct mddev *mddev, sector_t sector_nr, write_targets++; } } - if (bio->bi_end_io) { + if (rdev && bio->bi_end_io) { atomic_inc(&rdev->nr_pending); bio->bi_iter.bi_sector = sector_nr + rdev->data_offset; bio->bi_bdev = rdev->bdev; -- 2.20.1