From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B734C2D0D4 for ; Sun, 22 Dec 2019 14:40:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EC8D32070A for ; Sun, 22 Dec 2019 14:40:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="uNSUM4Xd" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726393AbfLVOkO (ORCPT ); Sun, 22 Dec 2019 09:40:14 -0500 Received: from mail-wm1-f50.google.com ([209.85.128.50]:34364 "EHLO mail-wm1-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725840AbfLVOkO (ORCPT ); Sun, 22 Dec 2019 09:40:14 -0500 Received: by mail-wm1-f50.google.com with SMTP id c127so5340941wme.1 for ; Sun, 22 Dec 2019 06:40:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=oy2LjJSLec2D59fijFx+c67E3+02VMx6+pY3xXIM7tc=; b=uNSUM4XdIsmMeLStHloN9C3c8woduTojbagMd9+QNQ/25pOnk8qryJXpxA0EDjBPNG iyNmmMDJ4A4TzjQV9xGT1Hv0ASfY9gCplTCnRNNITn3K/HJ0H/9NkafBSlhMGdmhHR5a xxu1jq0RqpJlki/ArX+Hw/0uO1y9xnS1SnZD4t/iTxjRMkPWTM3VuoRoXSd0ndavu+OZ GblyHWcQ0TaKhkgrD+oDm7WZPJm+xU3FL/AaKhEA1cptSsyT0n3rz7mrXg2bHENoMD6U Qd8DvWQqqjgE48ol/CAbq8AdpzYfkerWpDHhnjm2mdw8flCEHQ4wmWGqaJQNKVD/3byM U6Og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=oy2LjJSLec2D59fijFx+c67E3+02VMx6+pY3xXIM7tc=; b=IuIEe6TgntENgR6xIbQE2qq7x1+e5r6ChJvG9MIOFA6+0gCmeezE3KYNTI1UH2C8xI m+CTcsFc7LcmgLpHOnJ6gkJDryomI0PLSovjYGOj8BQRc7AHzQudUy4d1Gaars0/WsvZ OyLDkrvl+8GgrSCs7hTtx9UgZpbfoLL+jvOPy0Zl+wqV5AV0nxjrux+VfBdmJoxJvu/O 18Z8jOFHkfecxDkFF6X91cxpTpZLPZg5EEhWUaFurNhn7+CegzilxRkbBSV50yupMib9 YuJRaLSqC5BWhnfslijQe9QG+ovLQ+M3IupJrdcFbWeCBPudBxXnsM/ZpNIgm+GsCN4k /8PA== X-Gm-Message-State: APjAAAUQdunH/uJrQbgd+nTKCZ3FexqKzsW63FQ7xv0ktewWIErAkcbY 4swl89m5+WB2EJJpDgcTzOItK8M= X-Google-Smtp-Source: APXvYqzHJnblWg/+gDC0Y093ZJBWaUY+19oLjQsYrB4i/B8e+C2OwMreUCINzmHuq8YU03WDA35R2g== X-Received: by 2002:a1c:4857:: with SMTP id v84mr13786325wma.8.1577025612295; Sun, 22 Dec 2019 06:40:12 -0800 (PST) Received: from avx2 ([46.53.254.212]) by smtp.gmail.com with ESMTPSA id a16sm16959673wrt.37.2019.12.22.06.40.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Dec 2019 06:40:11 -0800 (PST) Date: Sun, 22 Dec 2019 17:40:09 +0300 From: Alexey Dobriyan To: akpm@linux-foundation.org Cc: linux-kernel@vger.kernel.org Subject: [PATCH -mm 2/3] ELF, coredump: delete duplicated overflow check Message-ID: <20191222144009.GB24341@avx2> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org array_size() macro will do overflow check anyway. Signed-off-by: Alexey Dobriyan --- fs/binfmt_elf.c | 2 -- 1 file changed, 2 deletions(-) --- a/fs/binfmt_elf.c +++ b/fs/binfmt_elf.c @@ -2257,8 +2257,6 @@ static int elf_core_dump(struct coredump_params *cprm) dataoff = offset = roundup(offset, ELF_EXEC_PAGESIZE); - if (segs - 1 > ULONG_MAX / sizeof(*vma_filesz)) - goto end_coredump; vma_filesz = kvmalloc(array_size(sizeof(*vma_filesz), (segs - 1)), GFP_KERNEL); if (ZERO_OR_NULL_PTR(vma_filesz))