From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 786B0C2D0C0 for ; Mon, 23 Dec 2019 15:24:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 429F4206B7 for ; Mon, 23 Dec 2019 15:24:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="EC+KEDyX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726880AbfLWPYL (ORCPT ); Mon, 23 Dec 2019 10:24:11 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:38378 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726733AbfLWPYL (ORCPT ); Mon, 23 Dec 2019 10:24:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Transfer-Encoding:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=WxhSTHErLYeR2xHJjtvGbHdEpZYHP8nE7fCcMzqkLxw=; b=EC+KEDyXA5qigr0fOio5UOp5Lj twfjpAZPPSiycoFg8GkflmX7znEdhgICR4BW/s/jxO9ubwzBVbfczcYeZ452vpiAnJ6Cud0QLnLh2 hV7ApBEbu3LTvDngxxWipuMZDsxYrGkKob0GK9UfWJdFv+vYbziuId7TZ3kOqu2jZ+1I=; Received: from andrew by vps0.lunn.ch with local (Exim 4.93) (envelope-from ) id 1ijPZ1-0005HR-KC; Mon, 23 Dec 2019 16:24:07 +0100 Date: Mon, 23 Dec 2019 16:24:07 +0100 From: Andrew Lunn To: "Jason A. Donenfeld" Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, davem@davemloft.net, Antoine Tenart Subject: Re: [PATCH net] of: mdio: mark stub of_mdiobus_child_is_phy as inline Message-ID: <20191223152407.GM32356@lunn.ch> References: <20191223132443.115540-1-Jason@zx2c4.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20191223132443.115540-1-Jason@zx2c4.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 23, 2019 at 02:24:43PM +0100, Jason A. Donenfeld wrote: > The of_mdiobus_child_is_phy function was recently exported, with a stub > fallback added to simply return false as a static function. The inline > specifier was left out, leading to build time errors: > > In file included from linux/include/linux/fs_enet_pd.h:21, > from linux/arch/powerpc/sysdev/fsl_soc.c:26: > linux/include/linux/of_mdio.h:58:13: error: ‘of_mdiobus_child_is_phy’ defined but not used [-Werror=unused-function] > 58 | static bool of_mdiobus_child_is_phy(struct device_node *child) > | ^~~~~~~~~~ > > This commit simply adds the missing inline keyboard. Hi Jason It is a good idea to search the netdev list before fixing things like this: https://lkml.org/lkml/2019/12/23/128 Andrew