From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5714FC2D0CF for ; Tue, 24 Dec 2019 12:01:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2EB072053B for ; Tue, 24 Dec 2019 12:01:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726246AbfLXMBo (ORCPT ); Tue, 24 Dec 2019 07:01:44 -0500 Received: from foss.arm.com ([217.140.110.172]:51556 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726102AbfLXMBn (ORCPT ); Tue, 24 Dec 2019 07:01:43 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2A6A61FB; Tue, 24 Dec 2019 04:01:43 -0800 (PST) Received: from localhost (unknown [10.37.6.20]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 92BDB3F534; Tue, 24 Dec 2019 04:01:42 -0800 (PST) Date: Tue, 24 Dec 2019 12:01:40 +0000 From: Andrew Murray To: Marc Zyngier Cc: will@kernel.org, Catalin Marinas , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Sudeep Holla , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 03/18] arm64: KVM: define SPE data structure for each vcpu Message-ID: <20191224120140.GH42593@e119886-lin.cambridge.arm.com> References: <20191220143025.33853-1-andrew.murray@arm.com> <20191220143025.33853-4-andrew.murray@arm.com> <20191221131936.21fa2dfa@why> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191221131936.21fa2dfa@why> User-Agent: Mutt/1.10.1+81 (426a6c1) (2018-08-26) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Dec 21, 2019 at 01:19:36PM +0000, Marc Zyngier wrote: > On Fri, 20 Dec 2019 14:30:10 +0000 > Andrew Murray wrote: > > > From: Sudeep Holla > > > > In order to support virtual SPE for guest, so define some basic structs. > > This features depends on host having hardware with SPE support. > > > > Since we can support this only on ARM64, add a separate config symbol > > for the same. > > > > Signed-off-by: Sudeep Holla > > [ Add irq_level, rename irq to irq_num for kvm_spe ] > > Signed-off-by: Andrew Murray > > --- > > arch/arm64/include/asm/kvm_host.h | 2 ++ > > arch/arm64/kvm/Kconfig | 7 +++++++ > > include/kvm/arm_spe.h | 19 +++++++++++++++++++ > > 3 files changed, 28 insertions(+) > > create mode 100644 include/kvm/arm_spe.h > > > > diff --git a/arch/arm64/include/asm/kvm_host.h b/arch/arm64/include/asm/kvm_host.h > > index c61260cf63c5..f5dcff912645 100644 > > --- a/arch/arm64/include/asm/kvm_host.h > > +++ b/arch/arm64/include/asm/kvm_host.h > > @@ -35,6 +35,7 @@ > > #include > > #include > > #include > > +#include > > > > #define KVM_MAX_VCPUS VGIC_V3_MAX_CPUS > > > > @@ -302,6 +303,7 @@ struct kvm_vcpu_arch { > > struct vgic_cpu vgic_cpu; > > struct arch_timer_cpu timer_cpu; > > struct kvm_pmu pmu; > > + struct kvm_spe spe; > > > > /* > > * Anything that is not used directly from assembly code goes > > diff --git a/arch/arm64/kvm/Kconfig b/arch/arm64/kvm/Kconfig > > index a475c68cbfec..af5be2c57dcb 100644 > > --- a/arch/arm64/kvm/Kconfig > > +++ b/arch/arm64/kvm/Kconfig > > @@ -35,6 +35,7 @@ config KVM > > select HAVE_KVM_EVENTFD > > select HAVE_KVM_IRQFD > > select KVM_ARM_PMU if HW_PERF_EVENTS > > + select KVM_ARM_SPE if (HW_PERF_EVENTS && ARM_SPE_PMU) > > select HAVE_KVM_MSI > > select HAVE_KVM_IRQCHIP > > select HAVE_KVM_IRQ_ROUTING > > @@ -61,6 +62,12 @@ config KVM_ARM_PMU > > Adds support for a virtual Performance Monitoring Unit (PMU) in > > virtual machines. > > > > +config KVM_ARM_SPE > > + bool > > + ---help--- > > + Adds support for a virtual Statistical Profiling Extension(SPE) in > > + virtual machines. > > + > > config KVM_INDIRECT_VECTORS > > def_bool KVM && (HARDEN_BRANCH_PREDICTOR || HARDEN_EL2_VECTORS) > > > > diff --git a/include/kvm/arm_spe.h b/include/kvm/arm_spe.h > > new file mode 100644 > > index 000000000000..48d118fdb174 > > --- /dev/null > > +++ b/include/kvm/arm_spe.h > > @@ -0,0 +1,19 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * Copyright (C) 2019 ARM Ltd. > > + */ > > + > > +#ifndef __ASM_ARM_KVM_SPE_H > > +#define __ASM_ARM_KVM_SPE_H > > + > > +#include > > +#include > > I don't believe these are required at this stage. > > > + > > +struct kvm_spe { > > + int irq_num; > > 'irq' was the right name *if* this represents a Linux irq. If this > instead represents a guest PPI, then it should be named 'intid'. > > In either case, please document what this represents. > > > + bool ready; /* indicates that SPE KVM instance is ready for use */ > > + bool created; /* SPE KVM instance is created, may not be ready yet */ > > + bool irq_level; > > What does this represent? The state of the interrupt on the host? The > guest? Something else? Also, please consider grouping related fields > together. It should be the state of the interrupt on the guest. > > > +}; > > If you've added a config option that controls the selection of the SPE > feature, why doesn't this result in an empty structure when it isn't > selected? OK, all noted. Andrew Murray > > > + > > +#endif /* __ASM_ARM_KVM_SPE_H */ > > Thanks, > > M. > -- > Jazz is not dead. It just smells funny...